2013-02-01 14:21:30

by Andre Guedes

Subject: [PATCH] Bluetooth: Refactor mgmt_pending_foreach

This patch does a trivial refactor in mgmt_pending_foreach function.
It replaces list_for_each_safe by list_for_each_entry_safe, simplifying
the function.

Signed-off-by: Andre Guedes <[email protected]>
---
net/bluetooth/mgmt.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 3bd4c41..39395c7 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -760,13 +760,9 @@ static void mgmt_pending_foreach(u16 opcode, struct hci_dev *hdev,
void *data),
void *data)
{
- struct list_head *p, *n;
-
- list_for_each_safe(p, n, &hdev->mgmt_pending) {
- struct pending_cmd *cmd;
-
- cmd = list_entry(p, struct pending_cmd, list);
+ struct pending_cmd *cmd, *tmp;

+ list_for_each_entry_safe(cmd, tmp, &hdev->mgmt_pending, list) {
if (opcode > 0 && cmd->opcode != opcode)
continue;

--
1.8.1.1

2013-02-01 17:27:10

by Gustavo Padovan

Subject: Re: [PATCH] Bluetooth: Refactor mgmt_pending_foreach

Hi Andre,

* Andre Guedes <[email protected]> [2013-02-01 11:21:30 -0300]:

> This patch does a trivial refactor in mgmt_pending_foreach function.
> It replaces list_for_each_safe by list_for_each_entry_safe, simplifying
> the function.
>
> Signed-off-by: Andre Guedes <[email protected]>
> ---
> net/bluetooth/mgmt.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)

Patch has been applied to bluetooth-next. Thanks.

Gustavo