2013-07-18 14:02:32

by Sathish Narasimman

[permalink] [raw]
Subject: [PATCH BlueZ] attrib: Fix interactive gatttool Segfault

From: Sathish N <[email protected]>

passing the special character single quote

$gatttool -I
[ ][ ][LE]> '
Segmentation fault (core dumped)

Checking g_shell_parse_argv fail status(return FALSE on failure), works fine.

hope the fix to the previous "git am" error is solved

---
attrib/interactive.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/attrib/interactive.c b/attrib/interactive.c
index f28dc22..df5dc52 100644
--- a/attrib/interactive.c
+++ b/attrib/interactive.c
@@ -867,7 +867,8 @@ static void parse_line(char *line_read)

add_history(line_read);

- g_shell_parse_argv(line_read, &argcp, &argvp, NULL);
+ if (g_shell_parse_argv(line_read, &argcp, &argvp, NULL) = FALSE)
+ goto done;

for (i = 0; commands[i].cmd; i++)
if (strcasecmp(commands[i].cmd, argvp[0]) == 0)
--
1.7.9.5