From: sathish N <[email protected]>
---
bluez/attrib/interactive.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/bluez/attrib/interactive.c b/bluez/attrib/interactive.c
index f28dc22..4fd7276 100644
--- a/bluez/attrib/interactive.c
+++ b/bluez/attrib/interactive.c
@@ -867,7 +867,8 @@ static void parse_line(char *line_read)
add_history(line_read);
- g_shell_parse_argv(line_read, &argcp, &argvp, NULL);
+ if (g_shell_parse_argv(line_read, &argcp, &argvp, NULL) == FALSE)
+ goto done;
for (i = 0; commands[i].cmd; i++)
if (strcasecmp(commands[i].cmd, argvp[0]) == 0)
--
1.7.9.5
Hi johan,
Yes it is my first submission. The full name is Sathish Narasimman.
solved the "git am" error and the patch is resubmitted(extra bluez/*
directory removed).
Thanks,
Sathish Narasimman
On Thursday 18 July 2013 04:46 PM, Johan Hedberg wrote:
> Hi Satish,
>
> On Thu, Jul 18, 2013, Sathish N wrote:
>> From: sathish N <[email protected]>
> Since this seems to be your first submission let me confirm these git
> author details: is this really how you want your author name to be, i.e.
> with a lower case "s" and just "N" as your surname? At least in your
> email "From" header your name was with a capital "S".
>
>> ---
>> bluez/attrib/interactive.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
> There seems to be something strange with your tree that generates this
> extra bluez/* path component. It makes "git am" fail to apply this
> patch:
>
> Applying: attrib: Fix interactive gatttool segfault
> error: bluez/attrib/interactive.c: does not exist in index
> Patch failed at 0001 attrib: Fix interactive gatttool segfault
>
> Besides the above issues the actual change to the code itself looks fine
> to me.
>
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Hi Satish,
On Thu, Jul 18, 2013, Sathish N wrote:
> From: sathish N <[email protected]>
Since this seems to be your first submission let me confirm these git
author details: is this really how you want your author name to be, i.e.
with a lower case "s" and just "N" as your surname? At least in your
email "From" header your name was with a capital "S".
> ---
> bluez/attrib/interactive.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
There seems to be something strange with your tree that generates this
extra bluez/* path component. It makes "git am" fail to apply this
patch:
Applying: attrib: Fix interactive gatttool segfault
error: bluez/attrib/interactive.c: does not exist in index
Patch failed at 0001 attrib: Fix interactive gatttool segfault
Besides the above issues the actual change to the code itself looks fine
to me.
Johan