2013-10-30 10:30:43

by Andrei Emeltchenko

[permalink] [raw]
Subject: [PATCH] android: Disable format warnings in Android

From: Andrei Emeltchenko <[email protected]>

Android's bionic library has bug defining ssize_t (which is fixed in
Android 4.3). This seems to be the most appropriate solution until
we move to Android 4.3.
---
android/Android.mk | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/android/Android.mk b/android/Android.mk
index fc1b276..db55d37 100644
--- a/android/Android.mk
+++ b/android/Android.mk
@@ -12,6 +12,10 @@ BLUEZ_COMMON_CFLAGS := -DVERSION=\"$(BLUEZ_VERSION)\"
# Disable warnings enabled by Android but not enabled in autotools build
BLUEZ_COMMON_CFLAGS += -Wno-pointer-arith

+# Disable warning: format '%zd' expects argument of type 'signed size_t',
+# but argument 4 has type 'ssize_t'
+BLUEZ_COMMON_CFLAGS += -Wno-format
+
#
# Android BlueZ daemon (bluetoothd)
#
--
1.7.10.4



2013-10-30 11:25:17

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] android: Disable format warnings in Android

Hi Andrei,

> Android's bionic library has bug defining ssize_t (which is fixed in
> Android 4.3). This seems to be the most appropriate solution until
> we move to Android 4.3.
> ---
> android/Android.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/android/Android.mk b/android/Android.mk
> index fc1b276..db55d37 100644
> --- a/android/Android.mk
> +++ b/android/Android.mk
> @@ -12,6 +12,10 @@ BLUEZ_COMMON_CFLAGS := -DVERSION=\"$(BLUEZ_VERSION)\"
> # Disable warnings enabled by Android but not enabled in autotools build
> BLUEZ_COMMON_CFLAGS += -Wno-pointer-arith
>
> +# Disable warning: format '%zd' expects argument of type 'signed size_t',
> +# but argument 4 has type 'ssize_t'
> +BLUEZ_COMMON_CFLAGS += -Wno-format

this disables now all format warnings. Even the useful ones. I am not in favor of doing this since it just leads to more error that otherwise the compiler would have caught.

Regards

Marcel