2014-02-21 13:58:49

by Andrzej Kaczmarek

Subject: [PATCH] android/socket: Fix calling cleanup with invalid pointer

---
android/socket.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/socket.c b/android/socket.c
index 48a8746..e2da689 100644
--- a/android/socket.c
+++ b/android/socket.c
@@ -1151,7 +1151,7 @@ void bt_socket_unregister(void)

for (ch = 0; ch <= RFCOMM_CHANNEL_MAX; ch++)
if (servers[ch].rfsock)
- cleanup_rfsock(&servers[ch]);
+ cleanup_rfsock(servers[ch].rfsock);

memset(servers, 0, sizeof(servers));

--
1.8.5.4

2014-02-21 14:30:08

by Szymon Janc

Subject: Re: [PATCH] android/socket: Fix calling cleanup with invalid pointer

Hi Andrzej,

On Friday 21 of February 2014 14:58:49 Andrzej Kaczmarek wrote:
> ---
> android/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/socket.c b/android/socket.c
> index 48a8746..e2da689 100644
> --- a/android/socket.c
> +++ b/android/socket.c
> @@ -1151,7 +1151,7 @@ void bt_socket_unregister(void)
>
> for (ch = 0; ch <= RFCOMM_CHANNEL_MAX; ch++)
> if (servers[ch].rfsock)
> - cleanup_rfsock(&servers[ch]);
> + cleanup_rfsock(servers[ch].rfsock);
>
> memset(servers, 0, sizeof(servers));
>

Pushed, thanks.

--
Best regards,
Szymon Janc