2014-05-16 10:47:32

by Lukasz Rymanowski

Subject: [PATCH] android/gatt: Fix for read request

If there is no attribute in database we should return immediately.
---
android/gatt.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/android/gatt.c b/android/gatt.c
index 9bbcc48..9d90f3a 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -3656,8 +3656,10 @@ static void read_requested_attributes(void *data, void *user_data)
resp_data->offset,
process_data->opcode,
&process_data->device->bdaddr,
- &value, &value_len))
+ &value, &value_len)) {
resp_data->length = READ_FAILED;
+ return;
+ }

/* We have value here already if no callback will be called */
if (value_len >= 0) {
--
1.8.4

2014-05-16 12:36:34

by Szymon Janc

Subject: Re: [PATCH] android/gatt: Fix for read request

Hi Łukasz,

On Friday 16 of May 2014 12:47:32 Lukasz Rymanowski wrote:
> If there is no attribute in database we should return immediately.
> ---
> android/gatt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 9bbcc48..9d90f3a 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -3656,8 +3656,10 @@ static void read_requested_attributes(void *data, void *user_data)
> resp_data->offset,
> process_data->opcode,
> &process_data->device->bdaddr,
> - &value, &value_len))
> + &value, &value_len)) {
> resp_data->length = READ_FAILED;
> + return;
> + }
>
> /* We have value here already if no callback will be called */
> if (value_len >= 0) {
>

Applied, thanks.

--
Best regards,
Szymon Janc