2014-06-09 08:18:50

by Andrei Emeltchenko

Subject: [PATCH] android/avrcp: Fix accessing pointer

From: Andrei Emeltchenko <[email protected]>

---
android/avrcp-lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/avrcp-lib.c b/android/avrcp-lib.c
index 12b6183..1de313b 100644
--- a/android/avrcp-lib.c
+++ b/android/avrcp-lib.c
@@ -1824,7 +1824,7 @@ static int parse_value(struct avrcp_header *pdu, uint8_t *number,
*/
if (*number > AVRCP_ATTRIBUTE_LAST ||
1 + *number * 2 != pdu->params_len) {
- number = 0;
+ *number = 0;
return -EPROTO;
}

--
1.8.3.2

2014-06-09 12:11:05

by Luiz Augusto von Dentz

Subject: Re: [PATCH] android/avrcp: Fix accessing pointer

Hi Andrei,

On Mon, Jun 9, 2014 at 11:18 AM, Andrei Emeltchenko
<[email protected]> wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> ---
> android/avrcp-lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/avrcp-lib.c b/android/avrcp-lib.c
> index 12b6183..1de313b 100644
> --- a/android/avrcp-lib.c
> +++ b/android/avrcp-lib.c
> @@ -1824,7 +1824,7 @@ static int parse_value(struct avrcp_header *pdu, uint8_t *number,
> */
> if (*number > AVRCP_ATTRIBUTE_LAST ||
> 1 + *number * 2 != pdu->params_len) {
> - number = 0;
> + *number = 0;
> return -EPROTO;
> }
>
> --
> 1.8.3.2

Pushed, thanks.


--
Luiz Augusto von Dentz