2014-08-20 13:06:47

by Andrei Emeltchenko

Subject: [PATCH] android: Fix header include

From: Andrei Emeltchenko <[email protected]>

Since Android KitKat we can use sys/prctl.h and sys/capability.h
as specified in the manual page. Fixes also build warnings:
...
warning: implicit declaration of function 'prctl'
[-Wimplicit-function-declaration]
if (prctl(PR_SET_KEEPCAPS, 1) < 0) {
^
...
---
android/main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/android/main.c b/android/main.c
index 0a0c150..5299789 100644
--- a/android/main.c
+++ b/android/main.c
@@ -36,10 +36,8 @@
#include <unistd.h>

#include <sys/signalfd.h>
-#if defined(ANDROID)
+#include <sys/prctl.h>
#include <sys/capability.h>
-#include <linux/prctl.h>
-#endif

#include <glib.h>

--
1.9.1

2014-08-22 08:20:49

by Szymon Janc

Subject: Re: [PATCH] android: Fix header include

Hi Andrei,

On Wednesday 20 of August 2014 16:06:47 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> Since Android KitKat we can use sys/prctl.h and sys/capability.h
> as specified in the manual page. Fixes also build warnings:
> ...
> warning: implicit declaration of function 'prctl'
> [-Wimplicit-function-declaration]
> if (prctl(PR_SET_KEEPCAPS, 1) < 0) {
> ^
> ...
> ---
> android/main.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/android/main.c b/android/main.c
> index 0a0c150..5299789 100644
> --- a/android/main.c
> +++ b/android/main.c
> @@ -36,10 +36,8 @@
> #include <unistd.h>
>
> #include <sys/signalfd.h>
> -#if defined(ANDROID)
> +#include <sys/prctl.h>
> #include <sys/capability.h>
> -#include <linux/prctl.h>
> -#endif
>
> #include <glib.h>
>
>

Applied. Thanks.

--
Best regards,
Szymon Janc