2014-08-11 07:17:02

by Andrei Emeltchenko

Subject: [PATCH] android/tester: Fix using uninitialized variable

From: Andrei Emeltchenko <[email protected]>

Fix typo not initializing variable. Silence warnings:

...
/android/tester-hdp.c: 71 in create_app()
/android/tester-hdp.c: 97 in create_app()
...
>>> Using uninitialized value "mdep2". Field
>>> "mdep2.mdep_description" is uninitialized.
71 reg->mdep_cfg[1] = mdep2;
...
>>> Using uninitialized value "mdep2". Field
>>> "mdep2.mdep_description" is uninitialized.
97 reg->mdep_cfg[1] = mdep2;
...
---
android/tester-hdp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/android/tester-hdp.c b/android/tester-hdp.c
index 9193609..bfe8a99 100644
--- a/android/tester-hdp.c
+++ b/android/tester-hdp.c
@@ -43,8 +43,9 @@ static bthl_reg_param_t *create_app(hdp_app_reg_type type)

mdep1.data_type = 4100;
mdep1.mdep_description = "pulse-oximeter";
+
mdep2.data_type = 4100;
- mdep1.mdep_description = "pulse-oximeter";
+ mdep2.mdep_description = "pulse-oximeter";

switch (type) {
case HDP_APP_SINK_RELIABLE:
--
1.9.1

2014-08-11 07:34:08

by Johan Hedberg

Subject: Re: [PATCH] android/tester: Fix using uninitialized variable

Hi Andrei,

On Mon, Aug 11, 2014, Andrei Emeltchenko wrote:
> Fix typo not initializing variable. Silence warnings:
>
> ...
> /android/tester-hdp.c: 71 in create_app()
> /android/tester-hdp.c: 97 in create_app()
> ...
> >>> Using uninitialized value "mdep2". Field
> >>> "mdep2.mdep_description" is uninitialized.
> 71 reg->mdep_cfg[1] = mdep2;
> ...
> >>> Using uninitialized value "mdep2". Field
> >>> "mdep2.mdep_description" is uninitialized.
> 97 reg->mdep_cfg[1] = mdep2;
> ...
> ---
> android/tester-hdp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Applied. Thanks.

Johan