2014-09-26 08:16:45

by Andrei Emeltchenko

Subject: [PATCH] android/core: Fix extra assignment

From: Andrei Emeltchenko <[email protected]>

prop is assigned in the beginning of for() loop. Fixes warning:
...
android/main.c:336:3: warning: Value stored to 'prop' is never read
prop = buf;
^ ~~~
...
---
android/main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/android/main.c b/android/main.c
index 663995e..2bc2dfe 100644
--- a/android/main.c
+++ b/android/main.c
@@ -334,7 +334,6 @@ static void configuration(const void *buf, uint16_t len)

buf += sizeof(*prop) + prop->len;
len -= sizeof(*prop) + prop->len;
- prop = buf;
}

ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_CORE, HAL_OP_CONFIGURATION,
--
1.9.1

2014-09-26 09:54:02

by Szymon Janc

Subject: Re: [PATCH] android/core: Fix extra assignment

Hi Andrei,

On Friday 26 of September 2014 11:16:45 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> prop is assigned in the beginning of for() loop. Fixes warning:
> ...
> android/main.c:336:3: warning: Value stored to 'prop' is never read
> prop = buf;
> ^ ~~~
> ...
> ---
> android/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/android/main.c b/android/main.c
> index 663995e..2bc2dfe 100644
> --- a/android/main.c
> +++ b/android/main.c
> @@ -334,7 +334,6 @@ static void configuration(const void *buf, uint16_t len)
>
> buf += sizeof(*prop) + prop->len;
> len -= sizeof(*prop) + prop->len;
> - prop = buf;
> }
>
> ipc_send_rsp(hal_ipc, HAL_SERVICE_ID_CORE, HAL_OP_CONFIGURATION,
>

Applied, thanks.

--
Best regards,
Szymon Janc