2014-12-30 06:27:48

by Syam Sidhardhan

Subject: [PATCH 1/1] tools/bluemoon: Remove dead code

return statement never get executed after goto.
---
tools/bluemoon.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/bluemoon.c b/tools/bluemoon.c
index 1fd516a..663d1f9 100644
--- a/tools/bluemoon.c
+++ b/tools/bluemoon.c
@@ -776,7 +776,6 @@ static void analyze_firmware(const char *path)
if (len != st.st_size) {
fprintf(stderr, "Failed to read complete firmware file\n");
goto done;
- return;
}

if ((size_t) len < sizeof(*css)) {
--
1.7.9.5

2015-01-08 09:50:13

by Johan Hedberg

Subject: Re: [PATCH 1/1] tools/bluemoon: Remove dead code

Hi Syam,

On Tue, Dec 30, 2014, Syam Sidhardhan wrote:
> return statement never get executed after goto.
> ---
> tools/bluemoon.c | 1 -
> 1 file changed, 1 deletion(-)

Applied. Thanks.

Johan

2015-01-07 20:04:43

by Syam Sidhardhan

Subject: Re: [PATCH 1/1] tools/bluemoon: Remove dead code

Hi,

On Tue, Dec 30, 2014 at 11:57 AM, Syam Sidhardhan <[email protected]> wrote:
> return statement never get executed after goto.
> ---
> tools/bluemoon.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/bluemoon.c b/tools/bluemoon.c
> index 1fd516a..663d1f9 100644
> --- a/tools/bluemoon.c
> +++ b/tools/bluemoon.c
> @@ -776,7 +776,6 @@ static void analyze_firmware(const char *path)
> if (len != st.st_size) {
> fprintf(stderr, "Failed to read complete firmware file\n");
> goto done;
> - return;
> }
>
> if ((size_t) len < sizeof(*css)) {
> --

ping