2014-12-19 13:50:54

by Gowtham Anandha Babu

Subject: [PATCH] profiles/hog: Remove dead code

warning: Value stored to 'attrib' is never read
attrib = report->hogdev->attrib;
^ ~~~~~~~~~~~~~~~~~~~~~~
---
profiles/input/hog.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/profiles/input/hog.c b/profiles/input/hog.c
index fb51663..74351f3 100644
--- a/profiles/input/hog.c
+++ b/profiles/input/hog.c
@@ -221,7 +221,6 @@ static void discover_descriptor_cb(uint8_t status, GSList *descs,
switch (desc->uuid16) {
case GATT_CLIENT_CHARAC_CFG_UUID:
report = user_data;
- attrib = report->hogdev->attrib;
write_ccc(desc->handle, report);
break;
case GATT_REPORT_REFERENCE:
--
1.9.1

2015-01-07 13:34:39

by Luiz Augusto von Dentz

Subject: Re: [PATCH] profiles/hog: Remove dead code

Hi,

On Wed, Jan 7, 2015 at 7:55 AM, Gowtham Anandha Babu
<[email protected]> wrote:
> Ping.
>
>> -----Original Message-----
>> From: [email protected] [mailto:linux-bluetooth-
>> [email protected]] On Behalf Of Gowtham Anandha Babu
>> Sent: Friday, December 19, 2014 7:21 PM
>> To: [email protected]
>> Cc: [email protected]; [email protected];
>> [email protected]; Gowtham Anandha Babu
>> Subject: [PATCH] profiles/hog: Remove dead code
>>
>> warning: Value stored to 'attrib' is never read
>> attrib = report->hogdev->attrib;
>> ^ ~~~~~~~~~~~~~~~~~~~~~~
>> ---
>> profiles/input/hog.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/profiles/input/hog.c b/profiles/input/hog.c index
>> fb51663..74351f3 100644
>> --- a/profiles/input/hog.c
>> +++ b/profiles/input/hog.c
>> @@ -221,7 +221,6 @@ static void discover_descriptor_cb(uint8_t status,
>> GSList *descs,
>> switch (desc->uuid16) {
>> case GATT_CLIENT_CHARAC_CFG_UUID:
>> report = user_data;
>> - attrib = report->hogdev->attrib;
>> write_ccc(desc->handle, report);
>> break;
>> case GATT_REPORT_REFERENCE:
>> --
>> 1.9.1

Applied, thanks.


--
Luiz Augusto von Dentz

2015-01-07 09:55:01

by Gowtham Anandha Babu

Subject: RE: [PATCH] profiles/hog: Remove dead code

Ping.

> -----Original Message-----
> From: [email protected] [mailto:linux-bluetooth-
> [email protected]] On Behalf Of Gowtham Anandha Babu
> Sent: Friday, December 19, 2014 7:21 PM
> To: [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; Gowtham Anandha Babu
> Subject: [PATCH] profiles/hog: Remove dead code
>
> warning: Value stored to 'attrib' is never read
> attrib = report->hogdev->attrib;
> ^ ~~~~~~~~~~~~~~~~~~~~~~
> ---
> profiles/input/hog.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/profiles/input/hog.c b/profiles/input/hog.c index
> fb51663..74351f3 100644
> --- a/profiles/input/hog.c
> +++ b/profiles/input/hog.c
> @@ -221,7 +221,6 @@ static void discover_descriptor_cb(uint8_t status,
> GSList *descs,
> switch (desc->uuid16) {
> case GATT_CLIENT_CHARAC_CFG_UUID:
> report = user_data;
> - attrib = report->hogdev->attrib;
> write_ccc(desc->handle, report);
> break;
> case GATT_REPORT_REFERENCE:
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
> the body of a message to [email protected] More majordomo
> info at http://vger.kernel.org/majordomo-info.html