2015-09-28 08:03:24

by Mutharaju, Prasanna (P.)

Subject: [PATCHv2] Bluetooth:hci_qca: Changed unsigned long to bool

From: Prasanna Karthik <[email protected]>

'retransmit' being set in HCI_IBS_TX_WAKING case, using bool would be
efficient. Initialize local bool to false.

Signed-off-by: Prasanna Karthik <[email protected]>
---
drivers/bluetooth/hci_qca.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index a8aa077..6fbd7d8 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -347,7 +347,7 @@ static void hci_ibs_wake_retrans_timeout(unsigned long =
arg)
struct hci_uart *hu =3D (struct hci_uart *)arg;
struct qca_data *qca =3D hu->priv;
unsigned long flags, retrans_delay;
- unsigned long retransmit =3D 0;
+ bool retransmit =3D false;
=20
BT_DBG("hu %p wake retransmit timeout in %d state",
hu, qca->tx_ibs_state);
@@ -358,7 +358,7 @@ static void hci_ibs_wake_retrans_timeout(unsigned long =
arg)
switch (qca->tx_ibs_state) {
case HCI_IBS_TX_WAKING:
/* No WAKE_ACK, retransmit WAKE */
- retransmit =3D 1;
+ retransmit =3D true;
if (send_hci_ibs_cmd(HCI_IBS_WAKE_IND, hu) < 0) {
BT_ERR("Failed to acknowledge device wake up");
break;
--=20
1.9.1

2015-09-28 11:07:20

by Marcel Holtmann

Subject: Re: [PATCHv2] Bluetooth:hci_qca: Changed unsigned long to bool

Hi Prasanna,

> 'retransmit' being set in HCI_IBS_TX_WAKING case, using bool would be
> efficient. Initialize local bool to false.
>
> Signed-off-by: Prasanna Karthik <[email protected]>
> ---
> drivers/bluetooth/hci_qca.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel