2015-09-03 21:08:45

by Vincent Stehlé

Subject: [PATCH] Bluetooth: btintel: fix warning

Fix compilation the following compilation warning, which happens when
CONFIG_BT_INTEL is not set:

drivers/bluetooth/btintel.h:98:13: warning: ‘btintel_version_info’
defined but not used [-Wunused-function]
static void btintel_version_info(struct hci_dev *hdev,
struct intel_version *ver)
^

Signed-off-by: Vincent Stehlé <[email protected]>
Cc: Marcel Holtmann <[email protected]>
Cc: [email protected]
---


Hi,

This warning can be seen with e.g. ARM imx_v6_v7_defconfig.

Best regards,

V.


drivers/bluetooth/btintel.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
index b278d14..a49c8db 100644
--- a/drivers/bluetooth/btintel.h
+++ b/drivers/bluetooth/btintel.h
@@ -95,7 +95,8 @@ static inline void btintel_hw_error(struct hci_dev *hdev, u8 code)
{
}

-static void btintel_version_info(struct hci_dev *hdev, struct intel_version *ver)
+static inline void btintel_version_info(struct hci_dev *hdev,
+ struct intel_version *ver)
{
}

--
2.5.0

2015-09-04 15:26:16

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: btintel: fix warning

Hi Vincent,

> Fix compilation the following compilation warning, which happens when
> CONFIG_BT_INTEL is not set:
>
> drivers/bluetooth/btintel.h:98:13: warning: ‘btintel_version_info’
> defined but not used [-Wunused-function]
> static void btintel_version_info(struct hci_dev *hdev,
> struct intel_version *ver)
> ^
>
> Signed-off-by: Vincent Stehlé <[email protected]>
> Cc: Marcel Holtmann <[email protected]>
> Cc: [email protected]
> ---
>
>
> Hi,
>
> This warning can be seen with e.g. ARM imx_v6_v7_defconfig.
>
> Best regards,
>
> V.
>
>
> drivers/bluetooth/btintel.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel