2020-12-03 03:49:23

by Manish Mandlik

Subject: [bluez PATCH v2 1/2] adv_monitor: Register client app with app-root-path

When a client app is registered with g_dbus_client_new(), bluez root
path, i.e. "/", is used as the app root path and signal watches are
added at that root path.

Because of this, InterfacesAdded/InterfacesRemoved signals emitted by
app - while creating/removing advertisement monitor objects at the
app root path - are not received by bluetoothd.

Use g_dbus_client_new_full() to register a client app with the correct
app root path.

Signed-off-by: Manish Mandlik <[email protected]>
Reviewed-by: [email protected]
Reviewed-by: [email protected]
Reviewed-by: [email protected]
---

Changes in v2:
- updated the commit message and title

src/adv_monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/adv_monitor.c b/src/adv_monitor.c
index fc058dbf1..a5bc61c48 100644
--- a/src/adv_monitor.c
+++ b/src/adv_monitor.c
@@ -775,7 +775,7 @@ static struct adv_monitor_app *app_create(DBusConnection *conn,
app->manager = manager;
app->reg = NULL;

- app->client = g_dbus_client_new(conn, sender, path);
+ app->client = g_dbus_client_new_full(conn, sender, path, path);
if (!app->client) {
app_destroy(app);
return NULL;
--
2.29.2.454.gaff20da3a2-goog

2020-12-03 04:40:18

by bluez.test.bot

Subject: RE: [bluez,v2,1/2] adv_monitor: Register client app with app-root-path

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=395121

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS



---
Regards,
Linux Bluetooth

2020-12-03 05:12:10

by Luiz Augusto von Dentz

Subject: Re: [bluez,v2,1/2] adv_monitor: Register client app with app-root-path

Hi Manish,

On Wed, Dec 2, 2020 at 8:42 PM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=395121
>
> ---Test result---
>
> ##############################
> Test: CheckPatch - PASS
>
> ##############################
> Test: CheckGitLint - PASS
>
> ##############################
> Test: CheckBuild - PASS
>
> ##############################
> Test: MakeCheck - PASS
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.

--
Luiz Augusto von Dentz