2021-04-07 05:37:19

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH 2/2] Bluetooth: LL privacy allow RPA

Hi Szymon,

>> allow RPA to add bd address to whitelist
>>
>> Signed-off-by: Sathish Narasimman <[email protected]>
>> ---
>> net/bluetooth/hci_request.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/net/bluetooth/hci_request.c b/net/bluetooth/hci_request.c
>> index 0d78122342d5..560b74d421a8 100644
>> --- a/net/bluetooth/hci_request.c
>> +++ b/net/bluetooth/hci_request.c
>> @@ -847,6 +847,10 @@ static u8 update_white_list(struct hci_request *req)
>> */
>> bool allow_rpa = hdev->suspended;
>>
>> + if (use_ll_privacy(hdev) &&
>> + hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY))
>> + allow_rpa = true;
>> +
>> /* Go through the current white list programmed into the
>> * controller one by one and check if that address is still
>> * in the list of pending connections or list of devices to
>
> I'm bit confused by this patch. Why add RPA to whitelist if LL privacy is in
> use?

if link layer privacy is enabled and the IRK programmed into the resolving list, we are now allowed to add the device to the white list.

Regards

Marcel