2021-08-31 05:45:22

by Yun-hao Chung

[permalink] [raw]
Subject: [Bluez PATCH v1] btmgmt: add non-interactive quit on read-sysconfig

From: Yun-Hao Chung <[email protected]>

This fixes the erros that read-sysconfig doesn't exit in non-interactive
mode.

Reviewed-by: Archie Pusaka <[email protected]>
---
Test with following commands
run "btmgmt read-sysconfig" and make sure it exits correctly

tools/btmgmt.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/btmgmt.c b/tools/btmgmt.c
index a840c428cc74..42ef9acefaea 100644
--- a/tools/btmgmt.c
+++ b/tools/btmgmt.c
@@ -1906,17 +1906,18 @@ static void read_sysconfig_rsp(uint8_t status, uint16_t len, const void *param,
if (status != 0) {
error("Read system configuration failed with status "
"0x%02x (%s)", status, mgmt_errstr(status));
- return;
+ return bt_shell_noninteractive_quit(EXIT_FAILURE);
}

tlv_list = mgmt_tlv_list_load_from_buf(param, len);
if (!tlv_list) {
error("Unable to parse response of read system configuration");
- return;
+ return bt_shell_noninteractive_quit(EXIT_FAILURE);
}

mgmt_tlv_list_foreach(tlv_list, print_mgmt_tlv, NULL);
mgmt_tlv_list_free(tlv_list);
+ bt_shell_noninteractive_quit(EXIT_SUCCESS);
}

static void cmd_read_sysconfig(int argc, char **argv)
--
2.33.0.259.gc128427fd7-goog