2022-06-06 05:16:40

by Miaoqian Lin

[permalink] [raw]
Subject: [PATCH] Bluetooth: btbcm: Fix refcount leak in btbcm_get_board_name

of_find_node_by_path() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.

Fixes: 63fac3343b99 ("Bluetooth: btbcm: Support per-board firmware variants")
Signed-off-by: Miaoqian Lin <[email protected]>
drivers/bluetooth/btbcm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 76fbb046bdbe..6f05054794e8 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -495,8 +495,10 @@ static const char *btbcm_get_board_name(struct device *dev)
if (!root)
return NULL;

- if (of_property_read_string_index(root, "compatible", 0, &tmp))
+ if (of_property_read_string_index(root, "compatible", 0, &tmp)) {
+ of_node_put(root);
return NULL;
+ }

/* get rid of any '/' in the compatible string */
len = strlen(tmp) + 1;

2022-06-06 05:25:18

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: btbcm: Fix refcount leak in btbcm_get_board_name

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=647420

---Test result---

Test Summary:
CheckPatch PASS 1.58 seconds
GitLint PASS 0.95 seconds
SubjectPrefix PASS 0.92 seconds
BuildKernel PASS 32.38 seconds
BuildKernel32 PASS 28.97 seconds
Incremental Build with patchesPASS 39.52 seconds
TestRunner: Setup PASS 478.23 seconds
TestRunner: l2cap-tester PASS 17.54 seconds
TestRunner: bnep-tester PASS 6.12 seconds
TestRunner: mgmt-tester PASS 102.36 seconds
TestRunner: rfcomm-tester PASS 9.75 seconds
TestRunner: sco-tester PASS 9.53 seconds
TestRunner: smp-tester PASS 9.60 seconds
TestRunner: userchan-tester PASS 6.45 seconds

Linux Bluetooth