2022-06-24 08:26:34

by Szymon Janc

[permalink] [raw]
Subject: [PATCH] monitor: Fix crash when using RTT backend

This fix regression introduced by "monitor: Fix memory leaks".
J-Link shared library is in use if jlink_init() returns 0 and thus
handle shall not be closed.
---
monitor/jlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/jlink.c b/monitor/jlink.c
index f1d8ce660..f9d4037f4 100644
--- a/monitor/jlink.c
+++ b/monitor/jlink.c
@@ -112,7 +112,7 @@ int jlink_init(void)
return -EIO;
}

- dlclose(so);
+ /* don't dlclose(so) here cause symbols from it are in use now */
return 0;
}

--
2.36.1


2022-06-24 09:36:28

by bluez.test.bot

[permalink] [raw]
Subject: RE: monitor: Fix crash when using RTT backend

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=653494

---Test result---

Test Summary:
CheckPatch PASS 1.09 seconds
GitLint PASS 0.73 seconds
Prep - Setup ELL PASS 43.22 seconds
Build - Prep PASS 0.55 seconds
Build - Configure PASS 8.74 seconds
Build - Make PASS 1280.85 seconds
Make Check PASS 11.53 seconds
Make Check w/Valgrind PASS 433.72 seconds
Make Distcheck PASS 225.36 seconds
Build w/ext ELL - Configure PASS 8.31 seconds
Build w/ext ELL - Make PASS 1228.49 seconds
Incremental Build with patchesPASS 0.00 seconds



---
Regards,
Linux Bluetooth

2022-06-27 08:33:51

by Szymon Janc

[permalink] [raw]
Subject: Re: monitor: Fix crash when using RTT backend

Hi,

On Fri, 24 Jun 2022 at 11:29, <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=653494
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 1.09 seconds
> GitLint PASS 0.73 seconds
> Prep - Setup ELL PASS 43.22 seconds
> Build - Prep PASS 0.55 seconds
> Build - Configure PASS 8.74 seconds
> Build - Make PASS 1280.85 seconds
> Make Check PASS 11.53 seconds
> Make Check w/Valgrind PASS 433.72 seconds
> Make Distcheck PASS 225.36 seconds
> Build w/ext ELL - Configure PASS 8.31 seconds
> Build w/ext ELL - Make PASS 1228.49 seconds
> Incremental Build with patchesPASS 0.00 seconds
>
>
>
> ---
> Regards,
> Linux Bluetooth
>

Applied.

--
pozdrawiam
Szymon K. Janc

2022-06-27 08:39:51

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] monitor: Fix crash when using RTT backend

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Szymon Janc <[email protected]>:

On Fri, 24 Jun 2022 10:25:41 +0200 you wrote:
> This fix regression introduced by "monitor: Fix memory leaks".
> J-Link shared library is in use if jlink_init() returns 0 and thus
> handle shall not be closed.
> ---
> monitor/jlink.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- monitor: Fix crash when using RTT backend
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1d6cfb8e625a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html