2022-09-20 03:31:09

by Yihao Han

[permalink] [raw]
Subject: [PATCH] Bluetooth: MGMT: fix zalloc-simple.cocci warnings

Use zeroing allocator rather than allocator followed by memset with 0

Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci

Signed-off-by: Yihao Han <[email protected]>
---
net/bluetooth/mgmt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index b9b64030a7b0..a92e7e485feb 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -4397,12 +4397,10 @@ static int read_exp_features_info(struct sock *sk, struct hci_dev *hdev,

/* Enough space for 7 features */
len = sizeof(*rp) + (sizeof(rp->features[0]) * 7);
- rp = kmalloc(len, GFP_KERNEL);
+ rp = kzalloc(len, GFP_KERNEL);
if (!rp)
return -ENOMEM;

- memset(rp, 0, len);
-
#ifdef CONFIG_BT_FEATURE_DEBUG
if (!hdev) {
flags = bt_dbg_get() ? BIT(0) : 0;
--
2.17.1


2022-09-20 03:58:09

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: MGMT: fix zalloc-simple.cocci warnings

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=678455

---Test result---

Test Summary:
CheckPatch PASS 1.86 seconds
GitLint PASS 0.81 seconds
SubjectPrefix PASS 0.61 seconds
BuildKernel PASS 46.58 seconds
BuildKernel32 PASS 40.20 seconds
Incremental Build with patchesPASS 60.07 seconds
TestRunner: Setup PASS 675.12 seconds
TestRunner: l2cap-tester PASS 20.67 seconds
TestRunner: iso-tester PASS 21.07 seconds
TestRunner: bnep-tester PASS 8.17 seconds
TestRunner: mgmt-tester PASS 130.62 seconds
TestRunner: rfcomm-tester PASS 12.84 seconds
TestRunner: sco-tester PASS 11.81 seconds
TestRunner: smp-tester PASS 11.98 seconds
TestRunner: userchan-tester PASS 8.70 seconds



---
Regards,
Linux Bluetooth

2022-09-20 21:41:11

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: MGMT: fix zalloc-simple.cocci warnings

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Mon, 19 Sep 2022 20:19:58 -0700 you wrote:
> Use zeroing allocator rather than allocator followed by memset with 0
>
> Generated by: scripts/coccinelle/api/alloc/zalloc-simple.cocci
>
> Signed-off-by: Yihao Han <[email protected]>
> ---
> net/bluetooth/mgmt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
- Bluetooth: MGMT: fix zalloc-simple.cocci warnings
https://git.kernel.org/bluetooth/bluetooth-next/c/239491111238

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html