2024-03-09 03:16:42

by Marek Vasut

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
This chip is present e.g. on muRata 1YN module. Extend the
binding with its DT compatible.

Signed-off-by: Marek Vasut <[email protected]>
---
Cc: "David S. Miller" <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Luiz Augusto von Dentz <[email protected]>
Cc: Marcel Holtmann <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
index cc70b00c6ce57..670bff0078ed7 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
@@ -27,6 +27,7 @@ properties:
- brcm,bcm4335a0
- brcm,bcm4349-bt
- cypress,cyw4373a0-bt
+ - infineon,cyw43439-bt
- infineon,cyw55572-bt

shutdown-gpios:
--
2.43.0



2024-03-09 03:16:50

by Marek Vasut

[permalink] [raw]
Subject: [PATCH 2/2] Bluetooth: hci_bcm: Add CYW43439 support

CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
This chip is present e.g. on muRata 1YN module. Extend the
driver to bind with it, even though the device binding is
most basic.

Signed-off-by: Marek Vasut <[email protected]>
---
NOTE: This comes up as the following, should the binding be
for 43439 (the chipset per muRata 1YN docs) or 4343A2?
Bluetooth: hci0: BCM: features 0x0e
Bluetooth: hci0: UART 4343A2 wlbga_BU
Bluetooth: hci0: BCM (001.003.016) build 0000
---
Cc: "David S. Miller" <[email protected]>
Cc: Conor Dooley <[email protected]>
Cc: Eric Dumazet <[email protected]>
Cc: Jakub Kicinski <[email protected]>
Cc: Krzysztof Kozlowski <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Luiz Augusto von Dentz <[email protected]>
Cc: Marcel Holtmann <[email protected]>
Cc: Paolo Abeni <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
---
drivers/bluetooth/hci_bcm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index 874d23089b39b..16b64b6ff7b1d 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -1608,6 +1608,7 @@ static const struct of_device_id bcm_bluetooth_of_match[] = {
{ .compatible = "brcm,bcm43540-bt", .data = &bcm4354_device_data },
{ .compatible = "brcm,bcm4335a0" },
{ .compatible = "cypress,cyw4373a0-bt", .data = &cyw4373a0_device_data },
+ { .compatible = "infineon,cyw43439-bt" },
{ .compatible = "infineon,cyw55572-bt", .data = &cyw55572_device_data },
{ },
};
--
2.43.0


2024-03-09 03:56:25

by bluez.test.bot

[permalink] [raw]
Subject: RE: [1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=833965

---Test result---

Test Summary:
CheckPatch PASS 1.03 seconds
GitLint PASS 0.50 seconds
SubjectPrefix FAIL 0.37 seconds
BuildKernel PASS 27.67 seconds
CheckAllWarning PASS 30.60 seconds
CheckSparse PASS 35.91 seconds
CheckSmatch PASS 98.04 seconds
BuildKernel32 PASS 26.54 seconds
TestRunnerSetup PASS 502.39 seconds
TestRunner_l2cap-tester PASS 17.73 seconds
TestRunner_iso-tester PASS 28.22 seconds
TestRunner_bnep-tester PASS 4.67 seconds
TestRunner_mgmt-tester PASS 112.79 seconds
TestRunner_rfcomm-tester PASS 7.24 seconds
TestRunner_sco-tester PASS 14.84 seconds
TestRunner_ioctl-tester PASS 7.67 seconds
TestRunner_mesh-tester PASS 5.73 seconds
TestRunner_smp-tester PASS 6.77 seconds
TestRunner_userchan-tester PASS 4.91 seconds
IncrementalBuild PASS 30.09 seconds

Details
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject


---
Regards,
Linux Bluetooth

2024-03-09 11:40:11

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

On 09/03/2024 04:15, Marek Vasut wrote:
> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> This chip is present e.g. on muRata 1YN module. Extend the
> binding with its DT compatible.
>
> Signed-off-by: Marek Vasut <[email protected]>
> ---
> Cc: "David S. Miller" <[email protected]>

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2024-03-17 15:03:49

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

On Sat, Mar 09, 2024 at 04:15:12AM +0100, Marek Vasut wrote:
> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> This chip is present e.g. on muRata 1YN module. Extend the
> binding with its DT compatible.

How come there's no fallback here? Looking at the binding patch there's
no device-specific handling done, what's incompatibly different between
this device and some of the other ones supported by the hci_bcm driver?

>
> Signed-off-by: Marek Vasut <[email protected]>
> ---
> Cc: "David S. Miller" <[email protected]>
> Cc: Conor Dooley <[email protected]>
> Cc: Eric Dumazet <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Krzysztof Kozlowski <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Luiz Augusto von Dentz <[email protected]>
> Cc: Marcel Holtmann <[email protected]>
> Cc: Paolo Abeni <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> ---
> Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> index cc70b00c6ce57..670bff0078ed7 100644
> --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
> @@ -27,6 +27,7 @@ properties:
> - brcm,bcm4335a0
> - brcm,bcm4349-bt
> - cypress,cyw4373a0-bt
> + - infineon,cyw43439-bt
> - infineon,cyw55572-bt
>
> shutdown-gpios:
> --
> 2.43.0
>


Attachments:
(No filename) (1.76 kB)
signature.asc (235.00 B)
Download all attachments

2024-03-19 18:10:17

by Marek Vasut

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

On 3/17/24 4:03 PM, Conor Dooley wrote:
> On Sat, Mar 09, 2024 at 04:15:12AM +0100, Marek Vasut wrote:
>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>> This chip is present e.g. on muRata 1YN module. Extend the
>> binding with its DT compatible.
>
> How come there's no fallback here? Looking at the binding patch there's
> no device-specific handling done, what's incompatibly different between
> this device and some of the other ones supported by the hci_bcm driver?

For posterity, should be addressed in V2.