From: Luiz Augusto von Dentz <[email protected]>
Fix not updating map.location when selecting.
---
src/shared/bap.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/shared/bap.c b/src/shared/bap.c
index f553096dfcc6..b452461ac715 100644
--- a/src/shared/bap.c
+++ b/src/shared/bap.c
@@ -5163,12 +5163,10 @@ int bt_bap_select(struct bt_bap_pac *lpac, struct bt_bap_pac *rpac,
/* Check if there are any channels left to select */
map.count &= ~(map.count & rc->count);
- if (!map.count)
- break;
-
/* Check if there are any locations left to select */
map.location &= ~(map.location & rc->location);
- if (!map.location)
+
+ if (!map.count || !map.location)
break;
/* Check if device require AC*(i) settings */
--
2.44.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=843632
---Test result---
Test Summary:
CheckPatch PASS 0.74 seconds
GitLint FAIL 0.75 seconds
BuildEll PASS 24.77 seconds
BluezMake PASS 1773.25 seconds
MakeCheck PASS 13.22 seconds
MakeDistcheck PASS 178.84 seconds
CheckValgrind PASS 251.96 seconds
CheckSmatch WARNING 366.36 seconds
bluezmakeextell PASS 124.40 seconds
IncrementalBuild PASS 3195.88 seconds
ScanBuild PASS 1055.92 seconds
Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,v1,2/2] shared/bap: Make bt_bap_select fallback in case of no channel allocation
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T1 Title exceeds max length (87>80): "[BlueZ,v1,2/2] shared/bap: Make bt_bap_select fallback in case of no channel allocation"
##############################
Test: CheckSmatch - WARNING
Desc: Run smatch tool with source
Output:
src/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible structuressrc/shared/bap.c:282:25: warning: array of flexible structuressrc/shared/bap.c: note: in included file:./src/shared/ascs.h:88:25: warning: array of flexible struct
ures
---
Regards,
Linux Bluetooth