2024-05-16 09:04:13

by Bastien Nocera

[permalink] [raw]
Subject: [BlueZ 07/15] test-runner: Fix uninitialised variable usage

Error: UNINIT (CWE-457): [#def64] [important]
bluez-5.75/tools/test-runner.c:701:2: var_decl: Declaring variable "envp" without initializer.
bluez-5.75/tools/test-runner.c:739:3: uninit_use_in_call: Using uninitialized value "*envp" when calling "execve".
737|
738| if (pid == 0) {
739|-> execve(argv[0], argv, envp);
740| exit(EXIT_SUCCESS);
741| }
---
tools/test-runner.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/test-runner.c b/tools/test-runner.c
index ff5e19825801..908327255ad7 100644
--- a/tools/test-runner.c
+++ b/tools/test-runner.c
@@ -698,7 +698,7 @@ static const char *btvirt_table[] = {
static pid_t start_btvirt(const char *home)
{
const char *btvirt = NULL;
- char *argv[3], *envp[2];
+ char *argv[3];
pid_t pid;
int i;

@@ -736,7 +736,7 @@ static pid_t start_btvirt(const char *home)
}

if (pid == 0) {
- execve(argv[0], argv, envp);
+ execv(argv[0], argv);
exit(EXIT_SUCCESS);
}

--
2.44.0