2024-06-03 12:54:37

by Janaki Ramaiah Thota

[permalink] [raw]
Subject: [PATCH] PENDING: Bluetooth: Increase settling time for baudrate change VSC

From: Harish Bandi <[email protected]>

This change is done to align the settling time and
synchronization for baudrate VSC for WCN6750.

In logging disabled builds and few devices
baudrate change and flow control is taking time
so increasing the wait time to controller and uart
to handle baudrate change request properly.

Change-Id: If0631cb886e53817f963f075e626c89a791b7be4
Signed-off-by: Harish Bandi <[email protected]>
---

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index eba9165..a59b35e 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -600,7 +600,6 @@
rom_ver = ((soc_ver & 0x00000f00) >> 0x04) | (soc_ver & 0x0000000f);

if (soc_type == QCA_WCN6750) {
- msleep(100);
qca_send_patch_config_cmd(hdev);
}

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index d8abd27..0b41214 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1356,11 +1356,13 @@
case QCA_WCN3990:
case QCA_WCN3991:
case QCA_WCN3998:
- case QCA_WCN6750:
case QCA_WCN6855:
case QCA_WCN7850:
usleep_range(1000, 10000);
break;
+ case QCA_WCN6750:
+ msleep(30);
+ break;

default:
msleep(300);
@@ -1904,7 +1906,6 @@
qca_set_speed(hu, QCA_INIT_SPEED);
}

- usleep_range(1000, 20000);
/* Setup user speed if needed */
speed = qca_get_speed(hu, QCA_OPER_SPEED);
if (speed) {


2024-06-03 12:54:49

by Janaki Ramaiah Thota

[permalink] [raw]
Subject: [PATCH v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC

This change is done to align the settling time and
synchronization for baudrate VSC for WCN6750.

In logging disabled builds and few devices
baudrate change and flow control is taking time
so increasing the wait time to controller and uart
to handle baudrate change request properly.

Signed-off-by: Janaki Ramaiah Thota <[email protected]>
---
drivers/bluetooth/hci_qca.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 0c9c9ee56592..667687835306 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -1356,12 +1356,15 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate)
case QCA_WCN3990:
case QCA_WCN3991:
case QCA_WCN3998:
- case QCA_WCN6750:
case QCA_WCN6855:
case QCA_WCN7850:
usleep_range(1000, 10000);
break;

+ case QCA_WCN6750:
+ msleep(30);
+ break;
+
default:
msleep(300);
}
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


2024-06-03 13:25:05

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v1] Bluetooth: hci_qca: Increase settling time for baudrate change VSC

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=858290

---Test result---

Test Summary:
CheckPatch PASS 0.70 seconds
GitLint PASS 0.34 seconds
SubjectPrefix PASS 0.14 seconds
BuildKernel PASS 29.93 seconds
CheckAllWarning PASS 32.48 seconds
CheckSparse PASS 37.91 seconds
CheckSmatch FAIL 36.07 seconds
BuildKernel32 PASS 28.59 seconds
TestRunnerSetup PASS 520.82 seconds
TestRunner_l2cap-tester PASS 20.30 seconds
TestRunner_iso-tester PASS 30.07 seconds
TestRunner_bnep-tester PASS 4.80 seconds
TestRunner_mgmt-tester PASS 111.73 seconds
TestRunner_rfcomm-tester PASS 7.35 seconds
TestRunner_sco-tester PASS 14.95 seconds
TestRunner_ioctl-tester PASS 7.83 seconds
TestRunner_mesh-tester PASS 5.88 seconds
TestRunner_smp-tester PASS 6.86 seconds
TestRunner_userchan-tester PASS 5.05 seconds
IncrementalBuild PASS 27.70 seconds

Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2


---
Regards,
Linux Bluetooth

2024-06-03 13:26:56

by bluez.test.bot

[permalink] [raw]
Subject: RE: PENDING: Bluetooth: Increase settling time for baudrate change VSC

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: drivers/bluetooth/btqca.c:600
error: drivers/bluetooth/btqca.c: patch does not apply
error: patch failed: drivers/bluetooth/hci_qca.c:1904
error: drivers/bluetooth/hci_qca.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth