2008-01-25 16:59:54

by Myklebust, Trond

[permalink] [raw]
Subject: [PATCH 090/112] NFS: nfs_write_end clean up

From: Chuck Lever <[email protected]>

Clean up: commit 4899f9c8 added nfs_write_end(), which introduces a
conditional expression that returns an unsigned integer in one arm and
a signed integer in the other.

Signed-off-by: Chuck Lever <[email protected]>
Signed-off-by: Trond Myklebust <[email protected]>
---

fs/nfs/file.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 4560fc2..ef57a5a 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -349,7 +349,9 @@ static int nfs_write_end(struct file *file, struct address_space *mapping,
unlock_page(page);
page_cache_release(page);

- return status < 0 ? status : copied;
+ if (status < 0)
+ return status;
+ return copied;
}

static void nfs_invalidate_page(struct page *page, unsigned long offset)