On Tuesday January 22, [email protected] wrote:
>
> ?
!
(i.e. Acked-By: NeilBrown <[email protected]>)
tnx.NB
>
> --b.
>
> commit 6685389d610950126f700d25f3d010c7049441c3
> Author: J. Bruce Fields <[email protected]>
> Date: Tue Jan 22 17:40:42 2008 -0500
>
> nfsd: more careful input validation in nfsctl write methods
>
> Neil Brown points out that we're checking buf[size-1] in a couple places
> without first checking whether size is zero.
>
> Actually, given the implementation of simple_transaction_get(), buf[-1]
> is zero, so in both of these cases the subsequent check of the value of
> buf[size-1] will catch this case.
>
> But it seems fragile to depend on that, so add explicit checks for this
> case.
>
> Signed-off-by: J. Bruce Fields <[email protected]>
> Cc: Neil Brown <[email protected]>