2008-02-11 22:12:38

by Chuck Lever III

[permalink] [raw]
Subject: [PATCH 06/11] NLM: LOCKD fails to load if CONFIG_SYSCTL is not set

Bruce Fields says:
"By the way, we've got another config-related nit here:


You can build lockd without CONFIG_SYSCTL set, but then the module will
fail to load."

It looks like sysctl is needed for passing nsm_local_state between the
user space and the kernel. If that's not available, NSM notification
from user space appears not to work.

It's not a fatal error if the nsm_local_state file doesn't exist, however
I've chosen to ensure CONFIG_SYSCTL is selected if LOCKD is selected. The
other choice is for nlm_init() to ignore the return code from the sysctl
root registration call, but I think administrators would be surprised
that NSM isn't working in this case.

Signed-off-by: Chuck Lever <[email protected]>

fs/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/Kconfig b/fs/Kconfig
index 6c4e17b..0c8f85d 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -1737,6 +1737,7 @@ config NFSD_V4

config LOCKD
+ select SYSCTL

config LOCKD_V4