2008-06-10 18:58:31

by Myklebust, Trond

[permalink] [raw]
Subject: Re: [PATCH 1/2] NFS: Move fs/nfs/iostat.h to include/linux

On Fri, 2008-06-06 at 10:22 -0700, Chuck Lever wrote:
> The fs/nfs/iostat.h header has definitions that were designed to be
> exposed
> to user space. Move the header under include/linux so user space can
> use
> the header in applications that read /proc/self/mountstats.

The correct way to do this is to move _only_ those parts which are
designed to be exposed to user space into include/linux, and leave the
#ifdef __KERNEL__ protected stuff where it is.

--
Trond Myklebust
Linux NFS client maintainer

NetApp
[email protected]
http://www.netapp.com