[resend with extended cc list]
Bruce,
We've reworked the v4.1 backchannel patches to use asynchronous RPCs.
We've also addressed the comments you made on the previous series (RFC
03, RFC 04, and RFC 05). We are still working to address Trond's
comments for RFC 03, but do not want to hold off the review of the rest
of the patches. Can you please consider the set for inclusion in
2.6.31, with the note that an update to RFC 03 will be coming soon.
[RFC 01/11] nfsd: cleanup nfs4.0 callback encode routines
[RFC 02/11] nfsd: minorversion support for the back channel
[RFC 03/11] nfsd41: sunrpc: svc_tcp_recv_record()
[RFC 04/11] nfsd41: sunrpc: Added rpc server-side backchannel handling
[RFC 05/11] nfsd41: callback infrastructure
[RFC 06/11] nfsd41: Backchannel: Add sequence arguments to callback RPC
arguments
[RFC 07/11] nfsd41: Backchannel: Server backchannel RPC wait queue
[RFC 08/11] nfsd41: Backchannel: Setup sequence information
[RFC 09/11] nfsd41: cb_sequence callback
[RFC 10/11] nfsd41: Backchannel: Implement cb_recall over NFSv4.1
[RFC 11/11] nfsd41: Refactor create_client()
Thanks,
- ricardo
On Fri, May 01, 2009 at 02:00:22AM +0300, Benny Halevy wrote:
> Bruce,
>
> After squashing and merging Ricardo's latest patchset
> please review the following patchset and consider for 2.6.31.
Note this will conflict with the pending changes I have to make the
current callbacks use asynchronous rpc tasks instead of
kthreads--apologies. I'll try to get those into for-2.6.31 tomorrow,
and then I hope you won't mind working on top of that?
--b.
>
> Thanks,
>
> Benny
>
> [RFC 01/10] nfsd: cleanup nfs4.0 callback encode routines
> [RFC 02/10] nfsd: minorversion support for the back channel
> [RFC 03/10] nfsd41: sunrpc: Added rpc server-side backchannel handling
> [RFC 04/10] nfsd41: Remember the auth flavor to use for callbacks
> [RFC 05/10] nfsd41: callback infrastructure
> [RFC 06/10] nfsd41: Backchannel: Add sequence arguments to callback RPC arguments
> [RFC 07/10] nfsd41: Backchannel: Server backchannel RPC wait queue
> [RFC 08/10] nfsd41: Backchannel: Setup sequence information
> [RFC 09/10] nfsd41: cb_sequence callback
> [RFC 10/10] nfsd41: cb_recall callback
It shouldn't be too bad. I'll go ahead and rework the patches on top of
your asynchronous RPC callback changes.
- ricardo
On 5/3/09 1:53 PM, "J. Bruce Fields" <[email protected]> wrote:
> On Fri, May 01, 2009 at 02:00:22AM +0300, Benny Halevy wrote:
>> Bruce,
>>
>> After squashing and merging Ricardo's latest patchset
>> please review the following patchset and consider for 2.6.31.
>
> Note this will conflict with the pending changes I have to make the
> current callbacks use asynchronous rpc tasks instead of
> kthreads--apologies. I'll try to get those into for-2.6.31 tomorrow,
> and then I hope you won't mind working on top of that?
>
> --b.
>
>>
>> Thanks,
>>
>> Benny
>>
>> [RFC 01/10] nfsd: cleanup nfs4.0 callback encode routines
>> [RFC 02/10] nfsd: minorversion support for the back channel
>> [RFC 03/10] nfsd41: sunrpc: Added rpc server-side backchannel handling
>> [RFC 04/10] nfsd41: Remember the auth flavor to use for callbacks
>> [RFC 05/10] nfsd41: callback infrastructure
>> [RFC 06/10] nfsd41: Backchannel: Add sequence arguments to callback RPC
>> arguments
>> [RFC 07/10] nfsd41: Backchannel: Server backchannel RPC wait queue
>> [RFC 08/10] nfsd41: Backchannel: Setup sequence information
>> [RFC 09/10] nfsd41: cb_sequence callback
>> [RFC 10/10] nfsd41: cb_recall callback
On Tue, May 05, 2009 at 09:11:28PM -0700, Labiaga, Ricardo wrote:
> It shouldn't be too bad. I'll go ahead and rework the patches on top of
> your asynchronous RPC callback changes.
OK, thanks. I've added them to for-2.6.31:
git://linux-nfs.org/~bfields/linux.git for-2.6.31
So easiest for me would be if the patches are against that.
--b.
>
> - ricardo
>
>
> On 5/3/09 1:53 PM, "J. Bruce Fields" <[email protected]> wrote:
>
> > On Fri, May 01, 2009 at 02:00:22AM +0300, Benny Halevy wrote:
> >> Bruce,
> >>
> >> After squashing and merging Ricardo's latest patchset
> >> please review the following patchset and consider for 2.6.31.
> >
> > Note this will conflict with the pending changes I have to make the
> > current callbacks use asynchronous rpc tasks instead of
> > kthreads--apologies. I'll try to get those into for-2.6.31 tomorrow,
> > and then I hope you won't mind working on top of that?
> >
> > --b.
> >
> >>
> >> Thanks,
> >>
> >> Benny
> >>
> >> [RFC 01/10] nfsd: cleanup nfs4.0 callback encode routines
> >> [RFC 02/10] nfsd: minorversion support for the back channel
> >> [RFC 03/10] nfsd41: sunrpc: Added rpc server-side backchannel handling
> >> [RFC 04/10] nfsd41: Remember the auth flavor to use for callbacks
> >> [RFC 05/10] nfsd41: callback infrastructure
> >> [RFC 06/10] nfsd41: Backchannel: Add sequence arguments to callback RPC
> >> arguments
> >> [RFC 07/10] nfsd41: Backchannel: Server backchannel RPC wait queue
> >> [RFC 08/10] nfsd41: Backchannel: Setup sequence information
> >> [RFC 09/10] nfsd41: cb_sequence callback
> >> [RFC 10/10] nfsd41: cb_recall callback
>