2011-04-20 15:07:34

by Benny Halevy

[permalink] [raw]
Subject: RE: [pnfs] pnfs read layoutget

This seems like a bug.
If I remember correctly, you are testing the files layout, right?
Does this also happen with the latest kernel v2.6.39-rc3
and / or pnfs-all-2.6.38?

Regards,

Benny

-----Original Message-----
From: quanli gui [mailto:[email protected]]
Sent: Wed 2011-04-20 11:47
To: linux-pnfs; Halevy, Benny
Subject: [pnfs] pnfs read layoutget

In the code of linux-kernel-2.6.31, we can see that before the read
operation there is the layoutget operation. But in the newly code, for
example, in linux-kernel-2.6.36, before the read operation there only is the
open operation. That meaning that we don't need to get the layout from the
mds? Why remove the layoutget operation before the read operation? How it
reflect on the source code?



2011-04-20 19:23:13

by Myklebust, Trond

[permalink] [raw]
Subject: RE: [pnfs] pnfs read layoutget

On Wed, 2011-04-20 at 11:05 -0400, Halevy, Benny wrote:
> This seems like a bug.

In 2.6.36?

> If I remember correctly, you are testing the files layout, right?
> Does this also happen with the latest kernel v2.6.39-rc3
> and / or pnfs-all-2.6.38?

We should definitely be calling layoutget from the 2.6.39-rc3 read code
assuming that the files layout module is being correctly loaded and that
the server is correctly advertising pNFS capabilities.

Cheers
Trond
--
Trond Myklebust
Linux NFS client maintainer

NetApp
[email protected]
http://www.netapp.com