2011-09-09 20:11:18

by Jim Rees

Subject: [PATCH] pnfsblock: fix size of upcall message

Make the status field explicitly 32 bits. "...it's unlikely that the kernel
and userspace would differ on the size of an int here, but it might be a
good idea to go ahead and make that explicitly 32 bits in case we end up
dealing with more exotic arches at some point in the future."

Suggested-by: Jeff Layton <[email protected]>
Signed-off-by: Jim Rees <[email protected]>
---
fs/nfs/blocklayout/blocklayout.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/blocklayout/blocklayout.h b/fs/nfs/blocklayout/blocklayout.h
index 8900396..42acf7e 100644
--- a/fs/nfs/blocklayout/blocklayout.h
+++ b/fs/nfs/blocklayout/blocklayout.h
@@ -150,7 +150,7 @@ BLK_LSEG2EXT(struct pnfs_layout_segment *lseg)
}

struct bl_dev_msg {
- int status;
+ int32_t status;
uint32_t major, minor;
};

--
1.7.4.1

2011-09-10 07:29:36

by Benny Halevy

Subject: Re: [PATCH] pnfsblock: fix size of upcall message

On 2011-09-09 13:11, Jim Rees wrote:
> Make the status field explicitly 32 bits. "...it's unlikely that the kernel
> and userspace would differ on the size of an int here, but it might be a
> good idea to go ahead and make that explicitly 32 bits in case we end up
> dealing with more exotic arches at some point in the future."
>
> Suggested-by: Jeff Layton <[email protected]>
> Signed-off-by: Jim Rees <[email protected]>

merged. thanks!

Benny

> ---
> fs/nfs/blocklayout/blocklayout.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/blocklayout/blocklayout.h b/fs/nfs/blocklayout/blocklayout.h
> index 8900396..42acf7e 100644
> --- a/fs/nfs/blocklayout/blocklayout.h
> +++ b/fs/nfs/blocklayout/blocklayout.h
> @@ -150,7 +150,7 @@ BLK_LSEG2EXT(struct pnfs_layout_segment *lseg)
> }
>
> struct bl_dev_msg {
> - int status;
> + int32_t status;
> uint32_t major, minor;
> };
>