2013-12-09 10:11:02

by Kinglong Mee

Subject: [PATCH] nfsd: get rid of unused macro definition

Since defined in Linux-2.6.12-rc2, READTIME has not been used.

Signed-off-by: Kinglong Mee <[email protected]>
---
fs/nfsd/nfs4xdr.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index ee7237f..fd48536 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -103,11 +103,6 @@ xdr_error: \
(x) = (u64)ntohl(*p++) << 32; \
(x) |= ntohl(*p++); \
} while (0)
-#define READTIME(x) do { \
- p++; \
- (x) = ntohl(*p++); \
- p++; \
-} while (0)
#define READMEM(x,nbytes) do { \
x = (char *)p; \
p += XDR_QUADLEN(nbytes); \
--
1.8.4.2

2013-12-12 16:36:21

by J. Bruce Fields

Subject: Re: [PATCH] nfsd: get rid of unused macro definition

On Mon, Dec 09, 2013 at 06:10:53PM +0800, Kinglong Mee wrote:
> Since defined in Linux-2.6.12-rc2, READTIME has not been used.

Thanks, applying.--b.

>
> Signed-off-by: Kinglong Mee <[email protected]>
> ---
> fs/nfsd/nfs4xdr.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
> index ee7237f..fd48536 100644
> --- a/fs/nfsd/nfs4xdr.c
> +++ b/fs/nfsd/nfs4xdr.c
> @@ -103,11 +103,6 @@ xdr_error: \
> (x) = (u64)ntohl(*p++) << 32; \
> (x) |= ntohl(*p++); \
> } while (0)
> -#define READTIME(x) do { \
> - p++; \
> - (x) = ntohl(*p++); \
> - p++; \
> -} while (0)
> #define READMEM(x,nbytes) do { \
> x = (char *)p; \
> p += XDR_QUADLEN(nbytes); \
> --
> 1.8.4.2