2015-03-11 17:04:16

by Julia Lawall

Subject: [PATCH 0/15] don't export static symbol

These patches remove EXPORT_SYMBOL or EXPORT_SYMBOL_GPL declarations on
static functions.

This was done using the following semantic patch:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
type T;
identifier f;
@@

static T f (...) { ... }

@@
identifier r.f;
declarer name EXPORT_SYMBOL;
@@

-EXPORT_SYMBOL(f);

@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@

-EXPORT_SYMBOL_GPL(f);
// </smpl>

2015-03-11 17:04:13

by Julia Lawall

Subject: [PATCH 1/15] NFSv4.1: don't export static symbol

From: Julia Lawall <[email protected]>

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
type T;
identifier f;
@@

static T f (...) { ... }

@@
identifier r.f;
declarer name EXPORT_SYMBOL_GPL;
@@

-EXPORT_SYMBOL_GPL(f);
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>

---
fs/nfs/pnfs.c | 2 --
1 file changed, 2 deletions(-)

diff -u -p a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1902,7 +1902,6 @@ static void pnfs_writehdr_free(struct nf
pnfs_put_lseg(hdr->lseg);
nfs_pgio_header_free(hdr);
}
-EXPORT_SYMBOL_GPL(pnfs_writehdr_free);

int
pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
@@ -2032,7 +2031,6 @@ static void pnfs_readhdr_free(struct nfs
pnfs_put_lseg(hdr->lseg);
nfs_pgio_header_free(hdr);
}
-EXPORT_SYMBOL_GPL(pnfs_readhdr_free);

int
pnfs_generic_pg_readpages(struct nfs_pageio_descriptor *desc)

2015-03-12 15:59:46

by Trond Myklebust

Subject: Re: [PATCH 1/15] NFSv4.1: don't export static symbol

On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
> From: Julia Lawall <[email protected]>
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name EXPORT_SYMBOL_GPL;
> @@
>
> -EXPORT_SYMBOL_GPL(f);
> // </smpl>
>
> Signed-off-by: Julia Lawall <[email protected]>
>
> ---
> fs/nfs/pnfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff -u -p a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -1902,7 +1902,6 @@ static void pnfs_writehdr_free(struct nf
> pnfs_put_lseg(hdr->lseg);
> nfs_pgio_header_free(hdr);
> }
> -EXPORT_SYMBOL_GPL(pnfs_writehdr_free);
>
> int
> pnfs_generic_pg_writepages(struct nfs_pageio_descriptor *desc)
> @@ -2032,7 +2031,6 @@ static void pnfs_readhdr_free(struct nfs
> pnfs_put_lseg(hdr->lseg);
> nfs_pgio_header_free(hdr);
> }
> -EXPORT_SYMBOL_GPL(pnfs_readhdr_free);
>
> int
> pnfs_generic_pg_readpages(struct nfs_pageio_descriptor *desc)
>

Thanks Julia! Applied....

--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
[email protected]