2016-09-22 17:32:13

by Scott Mayhew

[permalink] [raw]
Subject: [nfs-utils PATCH] mountstats: add pNFS READs and WRITEs

These counters are already in /proc/self/mountstats but the mountstats
program doesn't display them.

Signed-off-by: Scott Mayhew <[email protected]>
---
tools/mountstats/mountstats.py | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 4ca4bc4..88ccdae 100644
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -412,6 +412,8 @@ class DeviceData:
print(' short reads: %d short writes: %d' % \
(self.__nfs_data['shortreads'], self.__nfs_data['shortwrites']))
print(' NFSERR_DELAYs from server: %d' % self.__nfs_data['delay'])
+ print(' pNFS READs: %d' % self.__nfs_data['pnfsreads'])
+ print(' pNFS WRITEs: %d' % self.__nfs_data['pnfswrites'])

def display_nfs_bytes(self):
"""Pretty-print the NFS event counters
--
2.4.11



2016-09-22 17:35:15

by Steve Dickson

[permalink] [raw]
Subject: Re: [nfs-utils PATCH] mountstats: add pNFS READs and WRITEs



On 09/22/2016 01:32 PM, Scott Mayhew wrote:
> These counters are already in /proc/self/mountstats but the mountstats
> program doesn't display them.
>
> Signed-off-by: Scott Mayhew <[email protected]>
Committed.... Thanks!

steved.
> ---
> tools/mountstats/mountstats.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index 4ca4bc4..88ccdae 100644
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -412,6 +412,8 @@ class DeviceData:
> print(' short reads: %d short writes: %d' % \
> (self.__nfs_data['shortreads'], self.__nfs_data['shortwrites']))
> print(' NFSERR_DELAYs from server: %d' % self.__nfs_data['delay'])
> + print(' pNFS READs: %d' % self.__nfs_data['pnfsreads'])
> + print(' pNFS WRITEs: %d' % self.__nfs_data['pnfswrites'])
>
> def display_nfs_bytes(self):
> """Pretty-print the NFS event counters
>