2017-05-04 03:13:38

by Jason Yan

[permalink] [raw]
Subject: [PATCH] NFS: delete useless rcu_read_lock()

The rcu_read_lock in nfs_layout_find_inode_by_stateid and
nfs_layout_find_inode_by_fh is very confused, is it a clerical error?

Since it is already called in nfs_layout_find_inode, there's no need to
keep it here.

Signed-off-by: Jason Yan <[email protected]>
---
fs/nfs/callback_proc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c
index f073a6d2c..39c489f 100644
--- a/fs/nfs/callback_proc.c
+++ b/fs/nfs/callback_proc.c
@@ -131,7 +131,6 @@ static struct inode *nfs_layout_find_inode_by_stateid(struct nfs_client *clp,
if (!inode)
continue;
if (!nfs_sb_active(inode->i_sb)) {
- rcu_read_lock();
spin_unlock(&clp->cl_lock);
iput(inode);
spin_lock(&clp->cl_lock);
@@ -170,7 +169,6 @@ static struct inode *nfs_layout_find_inode_by_fh(struct nfs_client *clp,
if (!inode)
continue;
if (!nfs_sb_active(inode->i_sb)) {
- rcu_read_lock();
spin_unlock(&clp->cl_lock);
iput(inode);
spin_lock(&clp->cl_lock);
--
2.5.0