2020-10-23 16:31:03

by Chuck Lever III

Subject: [PATCH] NFSD: NFSv3 PATHCONF Reply is improperly formed

Commit cc028a10a48c ("NFSD: Hoist status code encoding into XDR
encoder functions") missed a spot.

Signed-off-by: Chuck Lever <[email protected]>
---
fs/nfsd/nfs3xdr.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/nfsd/nfs3xdr.c b/fs/nfsd/nfs3xdr.c
index 9c23b6acf234..2277f83da250 100644
--- a/fs/nfsd/nfs3xdr.c
+++ b/fs/nfsd/nfs3xdr.c
@@ -1114,6 +1114,7 @@ nfs3svc_encode_pathconfres(struct svc_rqst *rqstp, __be32 *p)
{
struct nfsd3_pathconfres *resp = rqstp->rq_resp;

+ *p++ = resp->status;
*p++ = xdr_zero; /* no post_op_attr */

if (resp->status == 0) {

2020-11-06 22:29:54

by J. Bruce Fields

Subject: Re: [PATCH] NFSD: NFSv3 PATHCONF Reply is improperly formed

Applied, thanks.--b.

On Fri, Oct 23, 2020 at 10:41:01AM -0400, Chuck Lever wrote:
> Commit cc028a10a48c ("NFSD: Hoist status code encoding into XDR
> encoder functions") missed a spot.
>
> Signed-off-by: Chuck Lever <[email protected]>
> ---
> fs/nfsd/nfs3xdr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfsd/nfs3xdr.c b/fs/nfsd/nfs3xdr.c
> index 9c23b6acf234..2277f83da250 100644
> --- a/fs/nfsd/nfs3xdr.c
> +++ b/fs/nfsd/nfs3xdr.c
> @@ -1114,6 +1114,7 @@ nfs3svc_encode_pathconfres(struct svc_rqst *rqstp, __be32 *p)
> {
> struct nfsd3_pathconfres *resp = rqstp->rq_resp;
>
> + *p++ = resp->status;
> *p++ = xdr_zero; /* no post_op_attr */
>
> if (resp->status == 0) {
>