2021-02-23 14:44:35

by Timo Rothenpieler

[permalink] [raw]
Subject: [PATCH] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default

This follows what was done in 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13.
With the default being m, it's impossible to build the module into the
kernel.

Signed-off-by: Timo Rothenpieler <[email protected]>
---
fs/nfs/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
index e2a488d403a6..14a72224b657 100644
--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig
@@ -127,7 +127,7 @@ config PNFS_BLOCK
config PNFS_FLEXFILE_LAYOUT
tristate
depends on NFS_V4_1 && NFS_V3
- default m
+ default NFS_V4

config NFS_V4_1_IMPLEMENTATION_ID_DOMAIN
string "NFSv4.1 Implementation ID Domain"
--
2.25.1


2021-02-23 14:58:50

by Trond Myklebust

[permalink] [raw]
Subject: Re: [PATCH] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default

On Tue, 2021-02-23 at 15:19 +0100, Timo Rothenpieler wrote:
> This follows what was done in
> 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13.
> With the default being m, it's impossible to build the module into
> the
> kernel.
>
> Signed-off-by: Timo Rothenpieler <[email protected]>
> ---
>  fs/nfs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> index e2a488d403a6..14a72224b657 100644
> --- a/fs/nfs/Kconfig
> +++ b/fs/nfs/Kconfig
> @@ -127,7 +127,7 @@ config PNFS_BLOCK
>  config PNFS_FLEXFILE_LAYOUT
>         tristate
>         depends on NFS_V4_1 && NFS_V3
> -       default m
> +       default NFS_V4
>  

Let's just make that

default y

...and let the dependencies work out whether or not this needs to be a
'y', 'm' or 'N'. Tying it to NFS_V4 just makes the Kconfig harder to
read, with the result being the same anyway.

>  config NFS_V4_1_IMPLEMENTATION_ID_DOMAIN
>         string "NFSv4.1 Implementation ID Domain"

--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
[email protected]


2021-02-23 15:00:10

by Timo Rothenpieler

[permalink] [raw]
Subject: Re: [PATCH] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default

On 23.02.2021 15:51, Trond Myklebust wrote:
> On Tue, 2021-02-23 at 15:19 +0100, Timo Rothenpieler wrote:
>> This follows what was done in
>> 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13.
>> With the default being m, it's impossible to build the module into
>> the
>> kernel.
>>
>> Signed-off-by: Timo Rothenpieler <[email protected]>
>> ---
>>  fs/nfs/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
>> index e2a488d403a6..14a72224b657 100644
>> --- a/fs/nfs/Kconfig
>> +++ b/fs/nfs/Kconfig
>> @@ -127,7 +127,7 @@ config PNFS_BLOCK
>>  config PNFS_FLEXFILE_LAYOUT
>>         tristate
>>         depends on NFS_V4_1 && NFS_V3
>> -       default m
>> +       default NFS_V4
>>
>
> Let's just make that
>
> default y
>
> ...and let the dependencies work out whether or not this needs to be a
> 'y', 'm' or 'N'. Tying it to NFS_V4 just makes the Kconfig harder to
> read, with the result being the same anyway.

Sure. Should I change the other two PNFS_ configs to default to y as
well while at it?


Attachments:
smime.p7s (4.39 kB)
S/MIME Cryptographic Signature

2021-02-23 15:05:31

by Trond Myklebust

[permalink] [raw]
Subject: Re: [PATCH] nfs: fix PNFS_FLEXFILE_LAYOUT Kconfig default

On Tue, 2021-02-23 at 15:54 +0100, Timo Rothenpieler wrote:
> On 23.02.2021 15:51, Trond Myklebust wrote:
> > On Tue, 2021-02-23 at 15:19 +0100, Timo Rothenpieler wrote:
> > > This follows what was done in
> > > 8c2fabc6542d9d0f8b16bd1045c2eda59bdcde13.
> > > With the default being m, it's impossible to build the module
> > > into
> > > the
> > > kernel.
> > >
> > > Signed-off-by: Timo Rothenpieler <[email protected]>
> > > ---
> > >   fs/nfs/Kconfig | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> > > index e2a488d403a6..14a72224b657 100644
> > > --- a/fs/nfs/Kconfig
> > > +++ b/fs/nfs/Kconfig
> > > @@ -127,7 +127,7 @@ config PNFS_BLOCK
> > >   config PNFS_FLEXFILE_LAYOUT
> > >          tristate
> > >          depends on NFS_V4_1 && NFS_V3
> > > -       default m
> > > +       default NFS_V4
> > >  
> >
> > Let's just make that
> >
> >      default y
> >
> > ...and let the dependencies work out whether or not this needs to
> > be a
> > 'y', 'm' or 'N'. Tying it to NFS_V4 just makes the Kconfig harder
> > to
> > read, with the result being the same anyway.
>
> Sure. Should I change the other two PNFS_ configs to default to y as
> well while at it?
>

Oh hang on... Brain fart... I thought the dependency on NFS_V4_1 would
suffice to make the correct choice, but it looks like that is a 'bool'
and so it won't propagate the 'm' choice from NFS_V4. That is probably
why Christoph did the NFS_V4 default.

Never mind, then. Let's keep your first patch.

--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
[email protected]