2011-09-13 21:59:12

by Mandeep Baines

[permalink] [raw]
Subject: Re: [PATCH] lib/sha1.c: quite sparse noise about symbol not declared

+cc linux-crypto, herbert, davem, torvalds

H Hartley Sweeten ([email protected]) wrote:
> Include <linux/cryptohash.h> to pickup the declarations for sha_transform
> and sha_init to quite the sparse noise:
>
> warning: symbol 'sha_transform' was not declared. Should it be static?
> warning: symbol 'sha_init' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Mandeep Singh Baines <[email protected]>
>

Acked-by: Mandeep Singh Baines <[email protected]>

Thanks.

> ---
>
> diff --git a/lib/sha1.c b/lib/sha1.c
> index f33271d..1de509a 100644
> --- a/lib/sha1.c
> +++ b/lib/sha1.c
> @@ -8,6 +8,7 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/bitops.h>
> +#include <linux/cryptohash.h>
> #include <asm/unaligned.h>
>
> /*


2011-09-22 11:33:29

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] lib/sha1.c: quite sparse noise about symbol not declared

On Tue, Sep 13, 2011 at 02:58:51PM -0700, [email protected] wrote:
> +cc linux-crypto, herbert, davem, torvalds
>
> H Hartley Sweeten ([email protected]) wrote:
> > Include <linux/cryptohash.h> to pickup the declarations for sha_transform
> > and sha_init to quite the sparse noise:
> >
> > warning: symbol 'sha_transform' was not declared. Should it be static?
> > warning: symbol 'sha_init' was not declared. Should it be static?
> >
> > Signed-off-by: H Hartley Sweeten <[email protected]>
> > Cc: Mandeep Singh Baines <[email protected]>
> >
>
> Acked-by: Mandeep Singh Baines <[email protected]>

Patch applied. Thanks!
--
Email: Herbert Xu <[email protected]ondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt