2012-03-28 06:51:06

by Steffen Klassert

[permalink] [raw]
Subject: [PATCH] crypto: pcrypt - Use the online cpumask as the default

We use the active cpumask to determine the superset of cpus
to use for parallelization. However, the active cpumask is
for internal usage of the scheduler and therefore not the
appropriate cpumask for these purposes. So use the online
cpumask instead.

Reported-by: Peter Zijlstra <[email protected]>
Signed-off-by: Steffen Klassert <[email protected]>
---
crypto/pcrypt.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c
index 29a89da..b2c99dc 100644
--- a/crypto/pcrypt.c
+++ b/crypto/pcrypt.c
@@ -280,11 +280,11 @@ static int pcrypt_aead_init_tfm(struct crypto_tfm *tfm)

ictx->tfm_count++;

- cpu_index = ictx->tfm_count % cpumask_weight(cpu_active_mask);
+ cpu_index = ictx->tfm_count % cpumask_weight(cpu_online_mask);

- ctx->cb_cpu = cpumask_first(cpu_active_mask);
+ ctx->cb_cpu = cpumask_first(cpu_online_mask);
for (cpu = 0; cpu < cpu_index; cpu++)
- ctx->cb_cpu = cpumask_next(ctx->cb_cpu, cpu_active_mask);
+ ctx->cb_cpu = cpumask_next(ctx->cb_cpu, cpu_online_mask);

cipher = crypto_spawn_aead(crypto_instance_ctx(inst));

@@ -472,7 +472,7 @@ static int pcrypt_init_padata(struct padata_pcrypt *pcrypt,
goto err_free_padata;
}

- cpumask_and(mask->mask, cpu_possible_mask, cpu_active_mask);
+ cpumask_and(mask->mask, cpu_possible_mask, cpu_online_mask);
rcu_assign_pointer(pcrypt->cb_cpumask, mask);

pcrypt->nblock.notifier_call = pcrypt_cpumask_change_notify;
--
1.7.0.4


2012-03-30 09:21:04

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: pcrypt - Use the online cpumask as the default

On Wed, Mar 28, 2012 at 08:51:03AM +0200, Steffen Klassert wrote:
> We use the active cpumask to determine the superset of cpus
> to use for parallelization. However, the active cpumask is
> for internal usage of the scheduler and therefore not the
> appropriate cpumask for these purposes. So use the online
> cpumask instead.
>
> Reported-by: Peter Zijlstra <[email protected]>
> Signed-off-by: Steffen Klassert <[email protected]et.com>

Applied to crypto.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt