2015-05-11 11:22:53

by Dan Streetman

Subject: [PATCH] crypto: make lib/842 decompress functions static

Make the do_index and do_op functions static.

They are used only internally by the 842 decompression function,
and should be static.

Reported-By: Fengguang Wu <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
Signed-off-by: Dan Streetman <[email protected]>
---
Oops, I missed making these static. Thanks for catching it!
I left your Signed-off-by even though this patch covers do_index
also (I assumed you agree with making both static :)

lib/842/842_decompress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/842/842_decompress.c b/lib/842/842_decompress.c
index 6b2b45a..dbeb058 100644
--- a/lib/842/842_decompress.c
+++ b/lib/842/842_decompress.c
@@ -214,7 +214,7 @@ static int __do_index(struct sw842_param *p, u8 size, u8 bits, u64 fsize)
return 0;
}

-int do_index(struct sw842_param *p, u8 n)
+static int do_index(struct sw842_param *p, u8 n)
{
switch (n) {
case 2:
@@ -228,7 +228,7 @@ int do_index(struct sw842_param *p, u8 n)
}
}

-int do_op(struct sw842_param *p, u8 o)
+static int do_op(struct sw842_param *p, u8 o)
{
int i, ret = 0;

--
2.1.0

2015-05-13 03:20:06

by Herbert Xu

Subject: Re: [PATCH] crypto: make lib/842 decompress functions static

On Mon, May 11, 2015 at 07:22:35AM -0400, Dan Streetman wrote:
> Make the do_index and do_op functions static.
>
> They are used only internally by the 842 decompression function,
> and should be static.
>
> Reported-By: Fengguang Wu <[email protected]>
> Signed-off-by: Fengguang Wu <[email protected]>
> Signed-off-by: Dan Streetman <[email protected]>

Applied.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt