2016-10-19 23:28:47

by Tudor-Dan Ambarus

Subject: provide DMA services in drivers/crypto

Hi, Herbert,

CAAM has the ability to provide DMA services. This is helpful for platforms that don't have a dedicated DMA hardware block.

In this particular example, caam being a crypto accelerator at its fundamentals, where is recommended to add a caam-dma engine implementation, in drivers/dma or in drivers/crypto? Are the any rules/guidelines?
I noticed that CCP already registered DMA services, the driver being held in drivers/crypto.

Thanks,
ta

2016-10-19 14:45:28

by Vinod Koul

Subject: Re: provide DMA services in drivers/crypto

On Wed, Oct 19, 2016 at 01:57:45PM +0000, Tudor-Dan Ambarus wrote:

Please wrap your mails within 80 chars, I have reflown below for reabability.

> Hi, Herbert,
>
> CAAM has the ability to provide DMA services. This is helpful for
> platforms that don't have a dedicated DMA hardware block.
>
> In this particular example, caam being a crypto accelerator at its
> fundamentals, where is recommended to add a caam-dma engine
> implementation, in drivers/dma or in drivers/crypto? Are the any
> rules/guidelines?

If the dma controller is internal to crypto, then it might be okay to be
inside the crypto driver. But if it is shared or common controller then a
dmaengine implementation would make sense..

> I noticed that CCP already registered DMA services, the driver being held
> in drivers/crypto.

I think drivers/crypto/ccp/ccp-dmaengine.c is wrong example, it should have
been in dmaengine directory. Not sure why it was addded in crypto :(

Thanks
--
~Vinod