2020-06-18 10:13:02

by Colin King

Subject: [PATCH] crypto: ccp: remove redundant assignment to variable ret

From: Colin Ian King <[email protected]>

The variable ret is being assigned with a value that is never read
and it is being updated later with a new value. The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/crypto/ccp/ccp-ops.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index 422193690fd4..d270aa792888 100644
--- a/drivers/crypto/ccp/ccp-ops.c
+++ b/drivers/crypto/ccp/ccp-ops.c
@@ -1308,7 +1308,6 @@ ccp_run_des3_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
return -EINVAL;
}

- ret = -EIO;
/* Zero out all the fields of the command desc */
memset(&op, 0, sizeof(op));

--
2.27.0.rc0

2020-06-18 13:53:29

by Tom Lendacky

Subject: Re: [PATCH] crypto: ccp: remove redundant assignment to variable ret

On 6/18/20 5:12 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable ret is being assigned with a value that is never read
> and it is being updated later with a new value. The assignment is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Tom Lendacky <[email protected]>

> ---
> drivers/crypto/ccp/ccp-ops.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
> index 422193690fd4..d270aa792888 100644
> --- a/drivers/crypto/ccp/ccp-ops.c
> +++ b/drivers/crypto/ccp/ccp-ops.c
> @@ -1308,7 +1308,6 @@ ccp_run_des3_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
> return -EINVAL;
> }
>
> - ret = -EIO;
> /* Zero out all the fields of the command desc */
> memset(&op, 0, sizeof(op));
>
>

2020-06-26 07:03:45

by Herbert Xu

Subject: Re: [PATCH] crypto: ccp: remove redundant assignment to variable ret

On Thu, Jun 18, 2020 at 11:12:29AM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable ret is being assigned with a value that is never read
> and it is being updated later with a new value. The assignment is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/crypto/ccp/ccp-ops.c | 1 -
> 1 file changed, 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt