Le Fri, Feb 11, 2022 at 02:13:00PM +0100, Johan Jonker a ?crit :
>
>
> On 2/11/22 12:59, Corentin Labbe wrote:
> > Convert rockchip-crypto to yaml
> >
> > Signed-off-by: Corentin Labbe <[email protected]>
> > ---
> > Changes since v1:
> > - fixed example
> > - renamed to a new name
> > - fixed some maxItems
> >
> > Change since v2:
> > - Fixed maintainers section
> >
> > .../crypto/rockchip,rk3288-crypto.yaml | 66 +++++++++++++++++++
> > .../bindings/crypto/rockchip-crypto.txt | 28 --------
> > 2 files changed, 66 insertions(+), 28 deletions(-)
>
> > create mode 100644 Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml
> > delete mode 100644 Documentation/devicetree/bindings/crypto/rockchip-crypto.txt
>
> There's more possible to this document:
>
> dt-bindings: crypto: rockchip: add support for px30
> https://github.com/rockchip-linux/kernel/commit/3655df1bc6114bda2a6417f39772a3cb008084ea
>
> crypto: rockchip - add px30 crypto aes/des support
> https://github.com/rockchip-linux/kernel/commit/ee082ae4f609f3b48f768420b31d8600448bd35a
>
Hello
The great advantage of out of tree code is that we can ignore it.
Anyway, if one day this code goes upstream, I think the new compatible should be in a new driver/module, both v1 and v2 are too different for me to be shared in the same driver.
But before upstreaming this code, the one in mainline should be fixed first, it fail self tests. (I have some patch partialy fixing it in progress)
Regards