2022-06-22 02:11:23

by Li Qiong

Subject: [PATCH] crypto: stm32 - Handle failure of kmalloc_array()

As the possible failure of the kmalloc_array(), therefore it
should be better to check it and return '-ENOMEM' on error.

Signed-off-by: Li Qiong <[email protected]>
---
drivers/crypto/stm32/stm32-hash.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
index d33006d43f76..fc03e32e364f 100644
--- a/drivers/crypto/stm32/stm32-hash.c
+++ b/drivers/crypto/stm32/stm32-hash.c
@@ -970,6 +970,8 @@ static int stm32_hash_export(struct ahash_request *req, void *out)
rctx->hw_context = kmalloc_array(3 + HASH_CSR_REGISTER_NUMBER,
sizeof(u32),
GFP_KERNEL);
+ if (!rctx->hw_context)
+ return -ENOMEM;

preg = rctx->hw_context;

--
2.11.0

2022-06-30 06:55:53

by Herbert Xu

Subject: Re: [PATCH] crypto: stm32 - Handle failure of kmalloc_array()

On Wed, Jun 22, 2022 at 10:02:08AM +0800, Li Qiong wrote:
> As the possible failure of the kmalloc_array(), therefore it
> should be better to check it and return '-ENOMEM' on error.
>
> Signed-off-by: Li Qiong <[email protected]>
> ---
> drivers/crypto/stm32/stm32-hash.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
> index d33006d43f76..fc03e32e364f 100644
> --- a/drivers/crypto/stm32/stm32-hash.c
> +++ b/drivers/crypto/stm32/stm32-hash.c
> @@ -970,6 +970,8 @@ static int stm32_hash_export(struct ahash_request *req, void *out)
> rctx->hw_context = kmalloc_array(3 + HASH_CSR_REGISTER_NUMBER,
> sizeof(u32),
> GFP_KERNEL);
> + if (!rctx->hw_context)
> + return -ENOMEM;

Actually the problem is bigger than that. The driver should not be
allocating memory in the export function at all. This memory will
be leaked as exported requests won't be finalized.

We need to fix this driver to do export properly, or if that's not
possible, we should delete this driver.

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt