2022-09-24 09:51:02

by Weili Qian

Subject: [PATCH] crypto: hisilicon/qm: drop unnecessary IS_ENABLE(CONFIG_NUMA) check

From: Yicong Yang <[email protected]>

dev_to_node() can handle the case when CONFIG_NUMA is not set, so the
check of CONFIG_NUMA is redundant and can be removed.

Signed-off-by: Yicong Yang <[email protected]>
Signed-off-by: Weili Qian <[email protected]>
---
drivers/crypto/hisilicon/qm.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index 8b387de69d22..9a38e170fb1d 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -4277,16 +4277,14 @@ static int hisi_qm_sort_devices(int node, struct list_head *head,
struct hisi_qm *qm;
struct list_head *n;
struct device *dev;
- int dev_node = 0;
+ int dev_node;

list_for_each_entry(qm, &qm_list->list, list) {
dev = &qm->pdev->dev;

- if (IS_ENABLED(CONFIG_NUMA)) {
- dev_node = dev_to_node(dev);
- if (dev_node < 0)
- dev_node = 0;
- }
+ dev_node = dev_to_node(dev);
+ if (dev_node < 0)
+ dev_node = 0;

res = kzalloc(sizeof(*res), GFP_KERNEL);
if (!res)
--
2.33.0

2022-10-21 11:37:08

by Herbert Xu

Subject: Re: [PATCH] crypto: hisilicon/qm: drop unnecessary IS_ENABLE(CONFIG_NUMA) check

On Sat, Sep 24, 2022 at 05:34:24PM +0800, Weili Qian wrote:
> From: Yicong Yang <[email protected]>
>
> dev_to_node() can handle the case when CONFIG_NUMA is not set, so the
> check of CONFIG_NUMA is redundant and can be removed.
>
> Signed-off-by: Yicong Yang <[email protected]>
> Signed-off-by: Weili Qian <[email protected]>
> ---
> drivers/crypto/hisilicon/qm.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt