2022-11-22 23:10:31

by Joe Fradley

Subject: [PATCH] crypto: x86/curve25519 - disable gcov

curve25519-x86_64.c fails to build when CONFIG_GCOV_KERNEL is enabled.
The error is "inline assembly requires more registers than available"
thrown from the `fsqr()` function. Therefore, excluding this file from
GCOV profiling until this issue is resolved. Thereby allowing
CONFIG_GCOV_PROFILE_ALL to be enabled for x86.

Signed-off-by: Joe Fradley <[email protected]>
---
arch/x86/crypto/Makefile | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/x86/crypto/Makefile b/arch/x86/crypto/Makefile
index 3b1d701a4f6c..3e7a329235bd 100644
--- a/arch/x86/crypto/Makefile
+++ b/arch/x86/crypto/Makefile
@@ -107,3 +107,6 @@ quiet_cmd_perlasm = PERLASM $@
cmd_perlasm = $(PERL) $< > $@
$(obj)/%.S: $(src)/%.pl FORCE
$(call if_changed,perlasm)
+
+# Disable GCOV in odd or sensitive code
+GCOV_PROFILE_curve25519-x86_64.o := n
--
2.38.1.584.g0f3c55d4c2-goog

2022-12-02 10:21:23

by Herbert Xu

Subject: Re: [PATCH] crypto: x86/curve25519 - disable gcov

On Tue, Nov 22, 2022 at 02:54:49PM -0800, Joe Fradley wrote:
> curve25519-x86_64.c fails to build when CONFIG_GCOV_KERNEL is enabled.
> The error is "inline assembly requires more registers than available"
> thrown from the `fsqr()` function. Therefore, excluding this file from
> GCOV profiling until this issue is resolved. Thereby allowing
> CONFIG_GCOV_PROFILE_ALL to be enabled for x86.
>
> Signed-off-by: Joe Fradley <[email protected]>
> ---
> arch/x86/crypto/Makefile | 3 +++
> 1 file changed, 3 insertions(+)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt