LinuxLists.cc - [PATCH 0/7] sysctl: Remove sentinel elements from misc directories

2024-03-28 15:59:29

Subject: [PATCH 0/7] sysctl: Remove sentinel elements from misc directories

From: Joel Granados <[email protected]>

What?
These commits remove the sentinel element (last empty element) from the
sysctl arrays of all the files under the "mm/", "security/", "ipc/",
"init/", "io_uring/", "drivers/perf/" and "crypto/" directories that
register a sysctl array. The inclusion of [4] to mainline allows the
removal of sentinel elements without behavioral change. This is safe
because the sysctl registration code (register_sysctl() and friends) use
the array size in addition to checking for a sentinel [1].

Why?
By removing the sysctl sentinel elements we avoid kernel bloat as
ctl_table arrays get moved out of kernel/sysctl.c into their own
respective subsystems. This move was started long ago to avoid merge
conflicts; the sentinel removal bit came after Mathew Wilcox suggested
it to avoid bloating the kernel by one element as arrays moved out. This
patchset will reduce the overall build time size of the kernel and run
time memory bloat by about ~64 bytes per declared ctl_table array (more
info here [5]).

When are we done?
There are 4 patchest (25 commits [2]) that are still outstanding to
completely remove the sentinels: files under "net/", files under
"kernel/" dir, misc dirs (this patchset) and the final set that removes
the unneeded check for ->procname == NULL.

Testing:
* Ran sysctl selftests (./tools/testing/selftests/sysctl/sysctl.sh)
* Ran this through 0-day with no errors or warnings

Savings in vmlinux:
A total of 64 bytes per sentinel is saved after removal; I measured in
x86_64 to give an idea of the aggregated savings. The actual savings
will depend on individual kernel configuration.
* bloat-o-meter
- The "yesall" config saves 963 bytes (bloat-o-meter output [6])
- A reduced config [3] saves 452 bytes (bloat-o-meter output [7])

Savings in allocated memory:
None in this set but will occur when the superfluous allocations are
removed from proc_sysctl.c. I include it here for context. The
estimated savings during boot for config [3] are 6272 bytes. See [8]
for how to measure it.

Comments/feedback greatly appreciated

Best

Joel

[1] https://lore.kernel.org/all/[email protected]/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/joel.granados/linux.git/tag/?h=sysctl_remove_empty_elem_v5
[3] https://gist.github.com/Joelgranados/feaca7af5537156ca9b73aeaec093171
[4] https://lore.kernel.org/all/ZO5Yx5JFogGi%[email protected]/

[5]
Links Related to the ctl_table sentinel removal:
* Good summaries from Luis:
https://lore.kernel.org/all/ZO5Yx5JFogGi%[email protected]/
https://lore.kernel.org/all/[email protected]/
* Patches adjusting sysctl register calls:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
* Discussions about expectations and approach
https://lore.kernel.org/all/[email protected]
https://lore.kernel.org/all/[email protected]

[6]
add/remove: 0/0 grow/shrink: 0/16 up/down: 0/-963 (-963)
Function old new delta
setup_mq_sysctls 502 499 -3
yama_sysctl_table 128 64 -64
vm_page_writeback_sysctls 512 448 -64
vm_oom_kill_table 256 192 -64
vm_compaction 320 256 -64
page_alloc_sysctl_table 576 512 -64
mq_sysctls 384 320 -64
memory_failure_table 192 128 -64
loadpin_sysctl_table 128 64 -64
key_sysctls 448 384 -64
kernel_io_uring_disabled_table 192 128 -64
kern_do_mounts_initrd_table 128 64 -64
ipc_sysctls 832 768 -64
hugetlb_vmemmap_sysctls 128 64 -64
hugetlb_table 320 256 -64
apparmor_sysctl_table 256 192 -64
Total: Before=440605433, After=440604470, chg -0.00%

[7]
add/remove: 0/0 grow/shrink: 0/8 up/down: 0/-452 (-452)
Function old new delta
setup_ipc_sysctls 306 302 -4
vm_page_writeback_sysctls 512 448 -64
vm_oom_kill_table 256 192 -64
page_alloc_sysctl_table 384 320 -64
key_sysctls 384 320 -64
kernel_io_uring_disabled_table 192 128 -64
ipc_sysctls 640 576 -64
hugetlb_table 256 192 -64
Total: Before=8523801, After=8523349, chg -0.01%

[8]
To measure the in memory savings apply this on top of this patchset.

"
diff --git i/fs/proc/proc_sysctl.c w/fs/proc/proc_sysctl.c
index 37cde0efee57..896c498600e8 100644
--- i/fs/proc/proc_sysctl.c
+++ w/fs/proc/proc_sysctl.c
@@ -966,6 +966,7 @@ static struct ctl_dir *new_dir(struct ctl_table_set *set,
table[0].procname = new_name;
table[0].mode = S_IFDIR|S_IRUGO|S_IXUGO;
init_header(&new->header, set->dir.header.root, set, node, table, 1);
+ printk("%ld sysctl saved mem kzalloc\n", sizeof(struct ctl_table));

return new;
}
@@ -1189,6 +1190,7 @@ static struct ctl_table_header *new_links(struct ctl_dir *dir, s>
link_name += len;
link++;
}
+ printk("%ld sysctl saved mem kzalloc\n", sizeof(struct ctl_table));
init_header(links, dir->header.root, dir->header.set, node, link_table,
head->ctl_table_size);
links->nreg = nr_entries;
"
and then run the following bash script in the kernel:

accum=0
for n in $(dmesg | grep kzalloc | awk '{print $3}') ; do
accum=$(calc "$accum + $n")
done
echo $accum

Signed-off-by: Joel Granados <[email protected]>

--

---
Joel Granados (7):
memory: Remove the now superfluous sentinel element from ctl_table array
security: Remove the now superfluous sentinel element from ctl_table array
crypto: Remove the now superfluous sentinel element from ctl_table array
initrd: Remove the now superfluous sentinel element from ctl_table array
ipc: Remove the now superfluous sentinel element from ctl_table array
io_uring: Remove the now superfluous sentinel elements from ctl_table array
drivers: perf: Remove the now superfluous sentinel elements from ctl_table array

crypto/fips.c | 1 -
drivers/perf/riscv_pmu_sbi.c | 1 -
init/do_mounts_initrd.c | 1 -
io_uring/io_uring.c | 1 -
ipc/ipc_sysctl.c | 1 -
ipc/mq_sysctl.c | 1 -
mm/compaction.c | 1 -
mm/hugetlb.c | 1 -
mm/hugetlb_vmemmap.c | 1 -
mm/memory-failure.c | 1 -
mm/oom_kill.c | 1 -
mm/page-writeback.c | 1 -
mm/page_alloc.c | 1 -
security/apparmor/lsm.c | 1 -
security/keys/sysctl.c | 1 -
security/loadpin/loadpin.c | 1 -
security/yama/yama_lsm.c | 1 -
17 files changed, 17 deletions(-)
---
base-commit: 4cece764965020c22cff7665b18a012006359095
change-id: 20240320-jag-sysctl_remset_misc-a261f5a7ddea

Best regards,
--
Joel Granados <[email protected]>

2024-03-28 15:59:37

by Joel Granados via B4 Relay

[permalink] [raw]

Subject: [PATCH 1/7] memory: Remove the now superfluous sentinel element from ctl_table array

From: Joel Granados <[email protected]>

This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which will
reduce the overall build time size of the kernel and run time memory
bloat by ~64 bytes per sentinel (further information Link :
https://lore.kernel.org/all/ZO5Yx5JFogGi%[email protected]/)

Remove sentinel from all files under mm/ that register a sysctl table.

Signed-off-by: Joel Granados <[email protected]>
---
mm/compaction.c | 1 -
mm/hugetlb.c | 1 -
mm/hugetlb_vmemmap.c | 1 -
mm/memory-failure.c | 1 -
mm/oom_kill.c | 1 -
mm/page-writeback.c | 1 -
mm/page_alloc.c | 1 -
7 files changed, 7 deletions(-)

diff --git a/mm/compaction.c b/mm/compaction.c
index 807b58e6eb68..e8a047afca22 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -3345,7 +3345,6 @@ static struct ctl_table vm_compaction[] = {
.extra1 = SYSCTL_ZERO,
.extra2 = SYSCTL_ONE,
},
- { }
};

static int __init kcompactd_init(void)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 23ef240ba48a..7ac5240a197d 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -5045,7 +5045,6 @@ static struct ctl_table hugetlb_table[] = {
.mode = 0644,
.proc_handler = hugetlb_overcommit_handler,
},
- { }
};

static void hugetlb_sysctl_init(void)
diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
index da177e49d956..b9a55322e52c 100644
--- a/mm/hugetlb_vmemmap.c
+++ b/mm/hugetlb_vmemmap.c
@@ -679,7 +679,6 @@ static struct ctl_table hugetlb_vmemmap_sysctls[] = {
.mode = 0644,
.proc_handler = proc_dobool,
},
- { }
};

static int __init hugetlb_vmemmap_init(void)
diff --git a/mm/memory-failure.c b/mm/memory-failure.c
index 9349948f1abf..6a112f9ecf91 100644
--- a/mm/memory-failure.c
+++ b/mm/memory-failure.c
@@ -141,7 +141,6 @@ static struct ctl_table memory_failure_table[] = {
.extra1 = SYSCTL_ZERO,
.extra2 = SYSCTL_ONE,
},
- { }
};

/*
diff --git a/mm/oom_kill.c b/mm/oom_kill.c
index 8d6a207c3c59..4d7a0004df2c 100644
--- a/mm/oom_kill.c
+++ b/mm/oom_kill.c
@@ -724,7 +724,6 @@ static struct ctl_table vm_oom_kill_table[] = {
.mode = 0644,
.proc_handler = proc_dointvec,
},
- {}
};
#endif

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 3e19b87049db..fba324e1a010 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2291,7 +2291,6 @@ static struct ctl_table vm_page_writeback_sysctls[] = {
.mode = 0644,
.proc_handler = proc_dointvec_jiffies,
},
- {}
};
#endif

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 14d39f34d336..8b9820620fe3 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -6211,7 +6211,6 @@ static struct ctl_table page_alloc_sysctl_table[] = {
.extra2 = SYSCTL_ONE_HUNDRED,
},
#endif
- {}
};

void __init page_alloc_sysctl_init(void)

--
2.43.0

2024-03-28 15:59:40

by Joel Granados via B4 Relay

[permalink] [raw]

Subject: [PATCH 2/7] security: Remove the now superfluous sentinel element from ctl_table array

From: Joel Granados <[email protected]>

This commit comes at the tail end of a greater effort to remove the
empty elements at the end of the ctl_table arrays (sentinels) which will
reduce the overall build time size of the kernel and run time memory
bloat by ~64 bytes per sentinel (further information Link :
https://lore.kernel.org/all/ZO5Yx5JFogGi%[email protected]/)

Remove the sentinel from all files under security/ that register a
sysctl table.

Signed-off-by: Joel Granados <[email protected]>
---
security/apparmor/lsm.c | 1 -
security/keys/sysctl.c | 1 -
security/loadpin/loadpin.c | 1 -
security/yama/yama_lsm.c | 1 -
4 files changed, 4 deletions(-)

diff --git a/security/apparmor/lsm.c b/security/apparmor/lsm.c
index cef8c466af80..6239777090c4 100644
--- a/security/apparmor/lsm.c
+++ b/security/apparmor/lsm.c
@@ -2064,7 +2064,6 @@ static struct ctl_table apparmor_sysctl_table[] = {
.mode = 0600,
.proc_handler = apparmor_dointvec,
},
- { }
};

static int __init apparmor_init_sysctl(void)
diff --git a/security/keys/sysctl.c b/security/keys/sysctl.c
index b348e1679d5d..91f000eef3ad 100644
--- a/security/keys/sysctl.c
+++ b/security/keys/sysctl.c
@@ -66,7 +66,6 @@ static struct ctl_table key_sysctls[] = {
.extra2 = (void *) SYSCTL_INT_MAX,
},
#endif
- { }
};

static int __init init_security_keys_sysctls(void)
diff --git a/security/loadpin/loadpin.c b/security/loadpin/loadpin.c
index 8e93cda130f1..93fd4d47b334 100644
--- a/security/loadpin/loadpin.c
+++ b/security/loadpin/loadpin.c
@@ -63,7 +63,6 @@ static struct ctl_table loadpin_sysctl_table[] = {
.extra1 = SYSCTL_ONE,
.extra2 = SYSCTL_ONE,
},
- { }
};

static void set_sysctl(bool is_writable)
diff --git a/security/yama/yama_lsm.c b/security/yama/yama_lsm.c
index 49dc52b454ef..b6684a074a59 100644
--- a/security/yama/yama_lsm.c
+++ b/security/yama/yama_lsm.c
@@ -463,7 +463,6 @@ static struct ctl_table yama_sysctl_table[] = {
.extra1 = SYSCTL_ZERO,
.extra2 = &max_scope,
},
- { }
};
static void __init yama_init_sysctl(void)
{

--
2.43.0

2024-03-28 15:59:52

by Joel Granados via B4 Relay

[permalink] [raw]

Subject: [PATCH 3/7] crypto: Remove the now superfluous sentinel element from ctl_table array

2024-03-28 16:00:02

by Joel Granados via B4 Relay

[permalink] [raw]

Subject: [PATCH 5/7] ipc: Remove the now superfluous sentinel element from ctl_table array

2024-03-28 16:00:06

by Joel Granados via B4 Relay

[permalink] [raw]

Subject: [PATCH 7/7] drivers: perf: Remove the now superfluous sentinel elements from ctl_table array

2024-03-28 16:00:20

by Joel Granados via B4 Relay

[permalink] [raw]

Subject: [PATCH 6/7] io_uring: Remove the now superfluous sentinel elements from ctl_table array

2024-03-28 16:03:32

by Joel Granados via B4 Relay

[permalink] [raw]

Subject: [PATCH 4/7] initrd: Remove the now superfluous sentinel element from ctl_table array

2024-03-28 23:05:32

by Jens Axboe

[permalink] [raw]

Subject: Re: (subset) [PATCH 0/7] sysctl: Remove sentinel elements from misc directories

On Thu, 28 Mar 2024 16:57:47 +0100, Joel Granados wrote:
> What?
> These commits remove the sentinel element (last empty element) from the
> sysctl arrays of all the files under the "mm/", "security/", "ipc/",
> "init/", "io_uring/", "drivers/perf/" and "crypto/" directories that
> register a sysctl array. The inclusion of [4] to mainline allows the
> removal of sentinel elements without behavioral change. This is safe
> because the sysctl registration code (register_sysctl() and friends) use
> the array size in addition to checking for a sentinel [1].
>
> [...]

Applied, thanks!

[6/7] io_uring: Remove the now superfluous sentinel elements from ctl_table array
(no commit info)

Best regards,
--
Jens Axboe

2024-04-01 03:22:19

by Muchun Song

[permalink] [raw]

Subject: Re: [PATCH 1/7] memory: Remove the now superfluous sentinel element from ctl_table array

> On Mar 28, 2024, at 23:57, Joel Granados via B4 Relay <[email protected]> wrote:
>
> From: Joel Granados <[email protected]>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which will
> reduce the overall build time size of the kernel and run time memory
> bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%[email protected]/)
>
> Remove sentinel from all files under mm/ that register a sysctl table.
>
> Signed-off-by: Joel Granados <[email protected]>

Reviewed-by: Muchun Song <[email protected]>

THanks.

2024-04-01 03:41:31

by Miaohe Lin

[permalink] [raw]

Subject: Re: [PATCH 1/7] memory: Remove the now superfluous sentinel element from ctl_table array

On 2024/3/28 23:57, Joel Granados via B4 Relay wrote:
> From: Joel Granados <[email protected]>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which will
> reduce the overall build time size of the kernel and run time memory
> bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%[email protected]/)
>
> Remove sentinel from all files under mm/ that register a sysctl table.
>
> Signed-off-by: Joel Granados <[email protected]>

Reviewed-by: Miaohe Lin <[email protected]>

Thanks.

> ---
> mm/compaction.c | 1 -
> mm/hugetlb.c | 1 -
> mm/hugetlb_vmemmap.c | 1 -
> mm/memory-failure.c | 1 -
> mm/oom_kill.c | 1 -
> mm/page-writeback.c | 1 -
> mm/page_alloc.c | 1 -
> 7 files changed, 7 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 807b58e6eb68..e8a047afca22 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -3345,7 +3345,6 @@ static struct ctl_table vm_compaction[] = {
> .extra1 = SYSCTL_ZERO,
> .extra2 = SYSCTL_ONE,
> },
> - { }
> };
>
> static int __init kcompactd_init(void)
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 23ef240ba48a..7ac5240a197d 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -5045,7 +5045,6 @@ static struct ctl_table hugetlb_table[] = {
> .mode = 0644,
> .proc_handler = hugetlb_overcommit_handler,
> },
> - { }
> };
>
> static void hugetlb_sysctl_init(void)
> diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c
> index da177e49d956..b9a55322e52c 100644
> --- a/mm/hugetlb_vmemmap.c
> +++ b/mm/hugetlb_vmemmap.c
> @@ -679,7 +679,6 @@ static struct ctl_table hugetlb_vmemmap_sysctls[] = {
> .mode = 0644,
> .proc_handler = proc_dobool,
> },
> - { }
> };
>
> static int __init hugetlb_vmemmap_init(void)
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index 9349948f1abf..6a112f9ecf91 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -141,7 +141,6 @@ static struct ctl_table memory_failure_table[] = {
> .extra1 = SYSCTL_ZERO,
> .extra2 = SYSCTL_ONE,
> },
> - { }
> };
>
> /*
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 8d6a207c3c59..4d7a0004df2c 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -724,7 +724,6 @@ static struct ctl_table vm_oom_kill_table[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec,
> },
> - {}
> };
> #endif
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 3e19b87049db..fba324e1a010 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2291,7 +2291,6 @@ static struct ctl_table vm_page_writeback_sysctls[] = {
> .mode = 0644,
> .proc_handler = proc_dointvec_jiffies,
> },
> - {}
> };
> #endif
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 14d39f34d336..8b9820620fe3 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6211,7 +6211,6 @@ static struct ctl_table page_alloc_sysctl_table[] = {
> .extra2 = SYSCTL_ONE_HUNDRED,
> },
> #endif
> - {}
> };
>
> void __init page_alloc_sysctl_init(void)
>

2024-04-09 17:00:37

by Will Deacon

[permalink] [raw]

Subject: Re: [PATCH 0/7] sysctl: Remove sentinel elements from misc directories

On Thu, 28 Mar 2024 16:57:47 +0100, Joel Granados wrote:
> What?
> These commits remove the sentinel element (last empty element) from the
> sysctl arrays of all the files under the "mm/", "security/", "ipc/",
> "init/", "io_uring/", "drivers/perf/" and "crypto/" directories that
> register a sysctl array. The inclusion of [4] to mainline allows the
> removal of sentinel elements without behavioral change. This is safe
> because the sysctl registration code (register_sysctl() and friends) use
> the array size in addition to checking for a sentinel [1].
>
> [...]

Applied drivers/perf change to will (for-next/perf), thanks!

[7/7] drivers: perf: Remove the now superfluous sentinel elements from ctl_table array
https://git.kernel.org/will/c/f66ae597411c

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

2024-04-05 07:58:19

by Herbert Xu

[permalink] [raw]

Subject: Re: [PATCH 3/7] crypto: Remove the now superfluous sentinel element from ctl_table array

On Thu, Mar 28, 2024 at 04:57:50PM +0100, Joel Granados via B4 Relay wrote:
> From: Joel Granados <[email protected]>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which will
> reduce the overall build time size of the kernel and run time memory
> bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%[email protected]/)
>
> Remove sentinel from crypto_sysctl_table
>
> Signed-off-by: Joel Granados <[email protected]>
> ---
> crypto/fips.c | 1 -
> 1 file changed, 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2024-04-15 13:44:57

by Joel Granados

[permalink] [raw]

Subject: Re: [PATCH 2/7] security: Remove the now superfluous sentinel element from ctl_table array

Hey

This is the only patch that I have not seen added to the next tree.
I'll put this in the sysctl-next
https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-next
for testing. Please let me know if It is lined up to be upstream through
another path.

Best

On Thu, Mar 28, 2024 at 04:57:49PM +0100, Joel Granados via B4 Relay wrote:
> From: Joel Granados <[email protected]>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which will
> reduce the overall build time size of the kernel and run time memory
> bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%[email protected]/)
>
...

--

Joel Granados

Attachments:

(No filename) (814.00 B)
signature.asc (673.00 B)
Download all attachments

2024-04-15 14:18:18

by Paul Moore

[permalink] [raw]

Subject: Re: [PATCH 2/7] security: Remove the now superfluous sentinel element from ctl_table array

On Mon, Apr 15, 2024 at 9:44 AM Joel Granados <[email protected]> wrote:
>
> Hey
>
> This is the only patch that I have not seen added to the next tree.
> I'll put this in the sysctl-next
> https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-next
> for testing. Please let me know if It is lined up to be upstream through
> another path.

I was hoping to see some ACKs from the associated LSM maintainers, but
it's minor enough I'll go ahead and pull it into the lsm/dev tree this
week. I'll send a note later when I do the merge.

--
paul-moore.com

2024-04-15 16:07:16

by Kees Cook

[permalink] [raw]

Subject: Re: [PATCH 2/7] security: Remove the now superfluous sentinel element from ctl_table array

On Thu, Mar 28, 2024 at 04:57:49PM +0100, Joel Granados via B4 Relay wrote:
> From: Joel Granados <[email protected]>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which will
> reduce the overall build time size of the kernel and run time memory
> bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%[email protected]/)
>
> Remove the sentinel from all files under security/ that register a
> sysctl table.
>
> Signed-off-by: Joel Granados <[email protected]>

Acked-by: Kees Cook <[email protected]> # loadpin & yama

--
Kees Cook

2024-04-15 19:03:02

by Paul Moore

[permalink] [raw]

Subject: Re: [PATCH 2/7] security: Remove the now superfluous sentinel element from ctl_table array

On Mon, Apr 15, 2024 at 10:17 AM Paul Moore <[email protected]> wrote:
> On Mon, Apr 15, 2024 at 9:44 AM Joel Granados <[email protected]> wrote:
> >
> > Hey
> >
> > This is the only patch that I have not seen added to the next tree.
> > I'll put this in the sysctl-next
> > https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-next
> > for testing. Please let me know if It is lined up to be upstream through
> > another path.
>
> I was hoping to see some ACKs from the associated LSM maintainers, but
> it's minor enough I'll go ahead and pull it into the lsm/dev tree this
> week. I'll send a note later when I do the merge.

... and now it's merged, it should be in the next cut of the
linux-next tree. Thanks!

--
paul-moore.com

2024-04-16 08:14:01

by Joel Granados

[permalink] [raw]

Subject: Re: [PATCH 2/7] security: Remove the now superfluous sentinel element from ctl_table array

On Mon, Apr 15, 2024 at 03:02:43PM -0400, Paul Moore wrote:
> On Mon, Apr 15, 2024 at 10:17 AM Paul Moore <[email protected]> wrote:
> > On Mon, Apr 15, 2024 at 9:44 AM Joel Granados <[email protected]> wrote:
> > >
> > > Hey
> > >
> > > This is the only patch that I have not seen added to the next tree.
> > > I'll put this in the sysctl-next
> > > https://git.kernel.org/pub/scm/linux/kernel/git/sysctl/sysctl.git/log/?h=sysctl-next
> > > for testing. Please let me know if It is lined up to be upstream through
> > > another path.
> >
> > I was hoping to see some ACKs from the associated LSM maintainers, but
> > it's minor enough I'll go ahead and pull it into the lsm/dev tree this
> > week. I'll send a note later when I do the merge.
>
> ... and now it's merged, it should be in the next cut of the
> linux-next tree. Thanks!

Awesome. I'll remove it from sysctl-next then to avoid any potential
crashes.

Thx

--

Joel Granados

Attachments:

(No filename) (980.00 B)
signature.asc (673.00 B)
Download all attachments