2007-02-10 02:14:26

by Brian Behlendorf

[permalink] [raw]
Subject: e2fsprogs coverity patch <cid-19.diff>

Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see
if it would identify any significant bugs. The analysis
turned up 38 mostly minor issues which are enumerated here
with patches. We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.

Brian Behlendorf <[email protected]>, and
Herb Wartens <[email protected]>

Coverity ID: 19: Resource Leak

Need to close old_f before returning since it had been successfully opened

Index: e2fsprogs+chaos/util/subst.c
--- e2fsprogs+chaos.orig/util/subst.c
+++ e2fsprogs+chaos/util/subst.c
@@ -273,8 +273,10 @@ static int compare_file(const char *outf
if (!old_f)
return 0;
new_f = fopen(newfn, "r");
- if (!new_f)
+ if (!new_f) {
+ fclose(old_f);
return 0;
+ }

while (1) {
oldcp = fgets(oldbuf, sizeof(oldbuf), old_f);