2007-02-10 02:14:20

by Brian Behlendorf

[permalink] [raw]
Subject: e2fsprogs coverity patch <cid-10.diff>

Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see
if it would identify any significant bugs. The analysis
turned up 38 mostly minor issues which are enumerated here
with patches. We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.

Brian Behlendorf <[email protected]>, and
Herb Wartens <[email protected]>

Coverity ID: 10: Null Returns

It is possible that e2fsck_get_dir_info() returns a NULL pointer.
We do not want to blow up when dereferencing p. It seems to be
more sane/safe to call fix_problem(ctx, PR_3_NO_DIRINFO, pctx)
if p is NULL at this point since we do not have any DIRINFO
for pctx->ino.

Index: e2fsprogs+chaos/e2fsck/pass3.c
--- e2fsprogs+chaos.orig/e2fsck/pass3.c
+++ e2fsprogs+chaos/e2fsck/pass3.c
@@ -306,6 +306,10 @@ static int check_directory(e2fsck_t ctx,
else {
p = e2fsck_get_dir_info(ctx, pctx->ino);
+ if(!p) {
+ fix_problem(ctx, PR_3_NO_DIRINFO, pctx);
+ return 0;
+ }
p->parent = ctx->lost_and_found;
fix_dotdot(ctx, p, ctx->lost_and_found);