2007-02-10 02:14:37

by Brian Behlendorf

[permalink] [raw]
Subject: e2fsprogs coverity patch <cid-32.diff>

Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see
if it would identify any significant bugs. The analysis
turned up 38 mostly minor issues which are enumerated here
with patches. We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.

Brian Behlendorf <[email protected]>, and
Herb Wartens <[email protected]>

Coverity ID: 32: Resource Leak

The memory allocated by inst is not reclaimed. There also was a
call to exit that coverity did not catch the resource leak. This
might not really be a big issue since the memory will be freed when
fsck exits, but it should be done anyway imho.

Index: e2fsprogs+chaos/misc/fsck.c
--- e2fsprogs+chaos.orig/misc/fsck.c
+++ e2fsprogs+chaos/misc/fsck.c
@@ -470,6 +470,7 @@ static int execute(const char *type, con
s = find_fsck(prog);
if (s == NULL) {
fprintf(stderr, _("fsck: %s: not found\n"), prog);
+ free(inst);
return ENOENT;

@@ -486,12 +487,14 @@ static int execute(const char *type, con
pid = -1;
else if ((pid = fork()) < 0) {
+ free(inst);
return errno;
} else if (pid == 0) {
if (!interactive)
(void) execv(s, argv);
+ free(inst);